Received: from eggs.gnu.org ([140.186.70.92]:53715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlLub-0003uW-K7 for qemu-devel@nongnu.org; Mon, 25 Jul 2011 10:13:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QlLua-00076e-2z for qemu-devel@nongnu.org; Mon, 25 Jul 2011 10:13:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QlLuZ-00076a-P4 for qemu-devel@nongnu.org; Mon, 25 Jul 2011 10:13:36 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p6PEDYns026023 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 25 Jul 2011 10:13:35 -0400 From: Markus Armbruster References: Date: Mon, 25 Jul 2011 16:13:33 +0200 In-Reply-To: (Amit Shah's message of "Wed, 20 Jul 2011 14:05:26 +0530") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah Cc: qemu list Amit Shah writes: > 'balloon 0' in the monitor causes a segfault. This happens because > the function that handles change in balloon values is also tasked with > handling stats retrieval from the guest, and it does the retrieval > when the balloon target is '0'. > > Silly API, replace it. Also do a few cleanups along the way. Silly indeed. Consider explaining the crash in 5/7's commit message. Reviewed-by: Markus Armbruster