Received: from [140.186.70.92] (port=45061 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJ0mW-0001pK-CF for qemu-devel@nongnu.org; Mon, 31 May 2010 04:55:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJ0dt-00067Y-8o for qemu-devel@nongnu.org; Mon, 31 May 2010 04:46:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59179) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJ0dt-00066T-2j for qemu-devel@nongnu.org; Mon, 31 May 2010 04:46:41 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH v2 12/15] monitor: Add basic device state visualization References: <1f557b9feb1965a61e64f7166bcf4918bed8d0ec.1274516288.git.jan.kiszka@web.de> <4BF82895.6000706@redhat.com> <4BF8DFF7.5070302@web.de> <4BF8EAFB.2080807@redhat.com> <4C00CCD4.7050904@web.de> <4C02212A.6060702@redhat.com> <4C025BC7.8070600@web.de> Date: Mon, 31 May 2010 10:46:36 +0200 In-Reply-To: <4C025BC7.8070600@web.de> (Jan Kiszka's message of "Sun, 30 May 2010 14:36:23 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , Juan Quintela , Jan Kiszka , qemu-devel@nongnu.org, Luiz Capitulino , Avi Kivity Jan Kiszka writes: > Avi Kivity wrote: >> On 05/29/2010 11:14 AM, Jan Kiszka wrote: >>>> Currently breaks down when IDs contain '/', but permitting that is a >>>> bug. There may be more problems; the path lookup code is way too >>>> clever. >>>> >>> Indeed. Less can sometimes be more. My impression is that some of the >>> cleverness was motivated by lacking qtree completion for the HMP. >>> >> >> Can we disable abbreviations for QMP and only allow them for HMP? >> >> We can support that by adding a hidden argument to commands specifying >> whether the input comes from a human or machine. Abbreviations are >> dangerous if they become ambiguous; a human can recover while a machine >> can't. >> > > Both QMP _and_ HMP suffer from ambitious and inconsistent addressing > schemes. Therefore, I'm more and more in favor of [1]. We just need to > add command line completion for option values, something that would be > beneficial for 'drive_add file=...' as well. > > Jan > > [1] http://article.gmane.org/gmane.comp.emulators.qemu/72152 [1] = abolish the clever abbreviations in path lookup. I agree we should do that.