Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nkasw-0002X0-55 for qemu-devel@nongnu.org; Thu, 25 Feb 2010 05:23:58 -0500 Received: from [199.232.76.173] (port=54446 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nkasv-0002Ws-F8 for qemu-devel@nongnu.org; Thu, 25 Feb 2010 05:23:57 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nkasu-0005Ao-Ec for qemu-devel@nongnu.org; Thu, 25 Feb 2010 05:23:57 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64814) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nkasu-0005Ai-2g for qemu-devel@nongnu.org; Thu, 25 Feb 2010 05:23:56 -0500 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1PANtT7020215 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Feb 2010 05:23:55 -0500 From: Markus Armbruster Date: Thu, 25 Feb 2010 11:23:52 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] [PATCH] scsi: Make device scsi-disk reject /dev/sg* List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann You're supposed to use scsi-generic for that. Which rejects anything but /dev/sg*. Signed-off-by: Markus Armbruster --- hw/scsi-disk.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index b2f61fe..ad8eb24 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -1027,6 +1027,11 @@ static int scsi_disk_initfn(SCSIDevice *dev) } s->bs = s->qdev.conf.dinfo->bdrv; + if (bdrv_is_sg(s->bs)) { + qemu_error("scsi-disk: unwanted /dev/sg*\n"); + return -1; + } + if (bdrv_get_type_hint(s->bs) == BDRV_TYPE_CDROM) { s->cluster_size = 4; } else { -- 1.6.6