Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NJUBX-0001BM-3u for qemu-devel@nongnu.org; Sat, 12 Dec 2009 10:47:07 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NJUBS-00018z-5C for qemu-devel@nongnu.org; Sat, 12 Dec 2009 10:47:06 -0500 Received: from [199.232.76.173] (port=56130 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NJUBR-00018f-Je for qemu-devel@nongnu.org; Sat, 12 Dec 2009 10:47:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64349) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NJUBP-0006xc-Ak for qemu-devel@nongnu.org; Sat, 12 Dec 2009 10:46:59 -0500 From: Juan Quintela In-Reply-To: <20091210180939.GA25707@redhat.com> (Michael S. Tsirkin's message of "Thu, 10 Dec 2009 20:09:39 +0200") References: <20091210180939.GA25707@redhat.com> Date: Sat, 12 Dec 2009 16:46:06 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 00/17] pci: switch a ton of drivers to symbolic names List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org "Michael S. Tsirkin" wrote: > The recent e1000 bug made the important of using > symbolic macros for pci config access clear for me. > So I started going over drivers and converting > to symbolic constants instead of hard-coded ones. > I did a large part until I run out of steam. > Maybe some brave soul will take up converting > the rest of them, or maybe I will: note that > when converting bridges one should be careful > to use bridge macros where appropriate. Nice patchset. And makes things way clear. Acked-by: Juan Quintela