Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVYai-0003dX-SY for qemu-devel@nongnu.org; Mon, 27 Jul 2009 18:22:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVYad-0003c3-Cm for qemu-devel@nongnu.org; Mon, 27 Jul 2009 18:22:43 -0400 Received: from [199.232.76.173] (port=37780 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVYad-0003bx-5Y for qemu-devel@nongnu.org; Mon, 27 Jul 2009 18:22:39 -0400 Received: from mx2.redhat.com ([66.187.237.31]:45236) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVYab-0004v6-PB for qemu-devel@nongnu.org; Mon, 27 Jul 2009 18:22:38 -0400 In-Reply-To: (malc's message of "Tue\, 28 Jul 2009 01\:10\:19 +0400 \(MSD\)") References: From: Juan Quintela Date: Tue, 28 Jul 2009 00:20:30 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 3/4] Use C99 initializers for audio_option List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org malc wrote: > On Mon, 27 Jul 2009, Juan Quintela wrote: > > I'd prefer: > > { .name = "DAC_SIZE_IN_USEC", > .tag = AUD_OPT_BOOL, > .valp = &conf.size_in_usec_out, > .descr = "DAC period/buffer size in microseconds (otherwise in frames)" }, > { ... > > And likewise elsewhere. I tried to be consistent with the qdev patches, they add all its "arrays of structures" this way (it is one of the bigger users of the feature that I saw). Later, Juan.