Received: from eggs.gnu.org ([140.186.70.92]:58026)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1R5Nel-0002NZ-Hg
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 16:08:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1R5Nek-0007Ja-3y
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 16:08:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2713)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <quintela@redhat.com>) id 1R5Nej-0007JI-N1
	for qemu-devel@nongnu.org; Sun, 18 Sep 2011 16:08:01 -0400
From: Juan Quintela <quintela@redhat.com>
In-Reply-To: <alpine.LNX.2.00.1109170251110.2328@linmac> (malc's message of
	"Sat, 17 Sep 2011 02:51:40 +0400 (MSD)")
References: <cover.1315918309.git.quintela@redhat.com>
	<4E734B4E.1070702@codemonkey.ws>
	<alpine.LNX.2.00.1109170251110.2328@linmac>
Date: Sun, 18 Sep 2011 22:07:35 +0200
Message-ID: <m3k495bomw.fsf@neno.neno>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse
Reply-To: quintela@redhat.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org

malc <av1474@comtv.ru> wrote:
> On Fri, 16 Sep 2011, Anthony Liguori wrote:
>
>> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
>> 
>> malc, please Ack.
>> 
>
> I don't like the commit message.

Can you be more specific?

Can you say what you will preffer?


>> On 09/13/2011 07:52 AM, Juan Quintela wrote:
>> > Hi
>> > 
>> > QEMUFile is intended to be used only for migration.  Change the other
>> > three users to use FILE * operations directly.  gcc on Fedora 15
>> > complains about fread/write not checking its return value, so I added
>> > checks.  But in several places only print an error message (there is
>> > no error handly that I can hook into).  Notice that this is not worse
>> > than it is today.
>> > 
>> > Later, Juan.
>> > 
>> > Juan Quintela (3):
>> >    vawaudio: port to FILE*
>> >    wavcapture: port to FILE*
>> >    ds1225y: port to FILE*
>> > 
>> >   audio/wavaudio.c   |   28 +++++++++++++++++++---------
>> >   audio/wavcapture.c |   38 +++++++++++++++++++++++++-------------
>> >   hw/ds1225y.c       |   28 ++++++++++++++++------------
>> >   3 files changed, 60 insertions(+), 34 deletions(-)
>> > 
>>