Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mslzq-0003NB-N7 for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:20:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mslzm-0003LC-7M for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:20:38 -0400 Received: from [199.232.76.173] (port=39681 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mslzl-0003L6-Uy for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:20:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43479) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mslzl-0001qE-GB for qemu-devel@nongnu.org; Tue, 29 Sep 2009 19:20:33 -0400 From: Juan Quintela In-Reply-To: <87zl8lbhf5.fsf@pike.pond.sub.org> (Markus Armbruster's message of "Wed, 23 Sep 2009 21:16:30 +0200") References: <6b781a1bec0f609301d111b0389fa9784f9629c9.1253536404.git.quintela@redhat.com> <87zl8lbhf5.fsf@pike.pond.sub.org> Date: Wed, 30 Sep 2009 01:20:23 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 1/2] cirrus_vga: also assign gr0/1 when writting shadow_gr0/1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org Markus Armbruster wrote: > Juan Quintela writes: > >> This is a regression/bug caused by previous vga_cleanup. This fixes >> Ubuntu installer reported by: >> Pierre Riteau >> >> Signed-off-by: Juan Quintela > > Broken in commit 22286bc6. Patch restores old behavior of > cirrus_vga_ioport_write() for address 0x3cf. > > But what about cirrus_mmio_blt_write() for address > CIRRUS_MMIO_BLTBGCOLOR + 0? There we had > > cirrus_hook_write_gr(s, 0x00, value); > > which did not update s->vga.gr[0x00]. It does with your patch, doesn't > it? > > Same for CIRRUS_MMIO_BLTFGCOLOR + 0. Yeap :( My VGA expertise is inexistent, I don't know what to do here. I will also fix that. Thanks for the review, Juan.