In-Reply-To: <4A716BCA.4050304@gnu.org> (Paolo Bonzini's message of "Thu\,
	30 Jul 2009 11\:45\:46 +0200")
References: <cover.1248918836.git.quintela@redhat.com>
	<ab3233d773b11a0c044a270d09e6e5ad261c13f9.1248918837.git.quintela@redhat.com>
	<4A7144A6.5060704@gnu.org> <m38wi61vys.fsf@neno.mitica>
	<4A7166FA.9070401@gnu.org> <m3prbizey9.fsf@neno.mitica>
	<4A716BCA.4050304@gnu.org>
From: Juan Quintela <quintela@redhat.com>
Date: Thu, 30 Jul 2009 11:54:57 +0200
Message-ID: <m3k51qzea6.fsf@neno.mitica>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: [Qemu-devel] Re: [PATCH 30/42] Rename CPPFLAGS to CFLAGS
To: Paolo Bonzini <bonzini@gnu.org>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org

Paolo Bonzini <bonzini@gnu.org> wrote:
>> Ok, and what are that options?
>> Looking at today Makefiles, the only things that I see that the user
>> could want changing is:
>>   -g
>>   -O2
>>   -fno-strict-aliasing
>>   -fno-unit-at-a-time (ppc)
>>   -msmall-data (alpha)
>>   -mno-sdata (ia64)
>>
>> Rest of things are -I/-D stuff, that you don't want to touch from the
>> command line at all.
>>
>> Anything else?  Should that be enough?
>
> I'd say only "-g -O2".
>
> -f and -m options should be left in QEMU_CFLAGS but CFLAGS should be
> expanded *after* it so that people can add
> -fstrict-aliasing/-funit-at-a-time/-mlarge-data/-msdata if they want
> to enable those options explicitly.
>
> The rationale is that probably "make CFLAGS=-g" would break the build
> on PPC, Alpha, and IA64; and "make CFLAGS='-O3 -g'" would break the
> build everywhere due to the lack of -fno-strict-aliasing.

Ok, with me, then the proposal is:
rename CFLAGS into QEMU_CFLAGS
leave in CFLAGS only "-g -O2"

Voters that agree?

Later, Juan.