Received: from [140.186.70.92] (port=52766 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJShj-0000t0-Bh for qemu-devel@nongnu.org; Tue, 01 Jun 2010 10:44:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJShi-00008t-6K for qemu-devel@nongnu.org; Tue, 01 Jun 2010 10:44:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25931) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJShi-00008e-0F for qemu-devel@nongnu.org; Tue, 01 Jun 2010 10:44:30 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH] qdev: Reject duplicate and anti-social device IDs References: <3715da16813f7cdcb7ec023167a84a94e8a37089.1274612367.git.jan.kiszka@web.de> <4C021ED5.1080703@redhat.com> <4C038882.3080007@redhat.com> <20100601100434.380c6ab3@redhat.com> Date: Tue, 01 Jun 2010 16:44:24 +0200 In-Reply-To: <20100601100434.380c6ab3@redhat.com> (Luiz Capitulino's message of "Tue, 1 Jun 2010 10:04:34 -0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , Juan Quintela , Jan Kiszka , qemu-devel@nongnu.org, Blue Swirl , Jan Kiszka , Gerd Hoffmann , Avi Kivity Luiz Capitulino writes: > On Mon, 31 May 2010 16:13:12 +0200 > Markus Armbruster wrote: > >> We need Device IDs to be unique and not contain '/' so device tree >> nodes can always be unambigously referenced by tree path. >> >> We already have some protection against duplicate IDs, but it got >> holes: >> >> * We don't assign IDs to default devices. >> >> * -device and device_add use the ID of a qemu_device_opts. Which >> rejects duplicate IDs. >> >> * pci_add nic -net use either the ID or option "name" of >> qemu_net_opts. And there's our hole. Reproducible with "-net user >> -net nic,id=foo -device lsi,id=foo". > > Two bugs that might not be related to this thread: > > * "id" member is not mandatory for the device_add command: > > { "execute": "device_add", "arguments": { "driver": "e1000" } } > {"return": {}} Works as designed. > * "id" member remains in use when the netdev_add command fails: > > { "execute": "netdev_add", "arguments": { "id": "foobar" } } > {"error": {"class": "MissingParameter", "desc": "Parameter 'type' is missing", "data": {"name": "type"}}} > > { "execute": "netdev_add", "arguments": { "type": "user", "id": "foobar" } } > {"error": {"class": "DuplicateId", "desc": "Duplicate ID 'foobar' for netdev", "data": {"object": "netdev", "id": "foobar"}}} Sounds like a bug.