Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Np5Dz-00008x-Kg for qemu-devel@nongnu.org; Tue, 09 Mar 2010 14:36:15 -0500 Received: from [199.232.76.173] (port=52319 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Np5Dx-0008Bc-Mh for qemu-devel@nongnu.org; Tue, 09 Mar 2010 14:36:13 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Np4yz-00030W-NN for qemu-devel@nongnu.org; Tue, 09 Mar 2010 14:20:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48381) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Np4yv-0002zU-G8 for qemu-devel@nongnu.org; Tue, 09 Mar 2010 14:20:41 -0500 From: Juan Quintela In-Reply-To: <1268160849.2579.56.camel@aglitke> (Adam Litke's message of "Tue, 09 Mar 2010 12:54:09 -0600") References: <1268160849.2579.56.camel@aglitke> Date: Tue, 09 Mar 2010 20:20:36 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] balloon: Do not save VM state wrt asynchronous virtio operations List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Adam Litke Cc: Anthony Liguori , Avi Kivity , qemu-devel@nongnu.org, Luiz Capitulino Adam Litke wrote: > When working with the VM state (for loadvm/savevm and migration), it is not > valid to load and store pointers since the validity of those pointers cannot be > assured in the new qemu address space. Therefore, virtio_balloon_save() and > virtio_balloon_load() must not handle the stats-related fields in struct > VirtIOBalloon. > > If a memory stats request is in-flight at the time of a migration or savevm, > the request will not complete and should be resubmitted once migration or > loadvm completes. Note that this extremely small race window can only be > triggered using QMP so it is not possible to hang the user monitor. > > Signed-off-by: Adam Litke Acked-by: Juan Quintela