Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nl1OF-0002iK-Ux for qemu-devel@nongnu.org; Fri, 26 Feb 2010 09:42:04 -0500 Received: from [199.232.76.173] (port=50109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nl1OF-0002i0-E7 for qemu-devel@nongnu.org; Fri, 26 Feb 2010 09:42:03 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nl1OE-0000Vc-3o for qemu-devel@nongnu.org; Fri, 26 Feb 2010 09:42:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55146) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nl1OD-0000V4-Lt for qemu-devel@nongnu.org; Fri, 26 Feb 2010 09:42:01 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1QEg05A013163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 26 Feb 2010 09:42:00 -0500 From: Markus Armbruster References: <20100225114256.GC9116@redhat.com> <20100225120848.GA9223@redhat.com> <4B868B6F.8050900@redhat.com> <4B879D00.5070400@redhat.com> Date: Fri, 26 Feb 2010 15:41:57 +0100 In-Reply-To: <4B879D00.5070400@redhat.com> (Gerd Hoffmann's message of "Fri, 26 Feb 2010 11:05:52 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] qdev: Catch attempt to attach more than one device to a netdev List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Mark McLoughlin , qemu-devel@nongnu.org, "Michael S. Tsirkin" Gerd Hoffmann writes: > On 02/26/10 10:30, Markus Armbruster wrote: >> This made a lot of sense if each parser threw largely different errors. >> Which isn't the case: we have one so far ("failed to parse"), and we >> just encountered a use for a second. > > There are actually three: parse error, not found > (netdev=) and busy (netdev=). > > But, yes, given the small number of error cases it makes sense to > generate the error one layer up and not in the parsers themself. Okay, I'll cook up v2.