Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MUS4X-0004m9-D5 for qemu-devel@nongnu.org; Fri, 24 Jul 2009 17:12:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MUS4T-0004lJ-1F for qemu-devel@nongnu.org; Fri, 24 Jul 2009 17:12:57 -0400 Received: from [199.232.76.173] (port=35797 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MUS4S-0004lG-Pu for qemu-devel@nongnu.org; Fri, 24 Jul 2009 17:12:52 -0400 Received: from mx2.redhat.com ([66.187.237.31]:35377) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MUS4S-0001ig-AB for qemu-devel@nongnu.org; Fri, 24 Jul 2009 17:12:52 -0400 In-Reply-To: <20090724204628.GU32566@codesourcery.com> (Nathan Froyd's message of "Fri\, 24 Jul 2009 13\:46\:28 -0700") References: <22a7a2be00a22a4ab3bbb4fdc634ab7aaacd8d6e.1248459711.git.quintela@redhat.com> <20090724204628.GU32566@codesourcery.com> From: Juan Quintela Date: Fri, 24 Jul 2009 23:10:42 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 22/46] rename HAVE_MACHINE_BSWAP_H to CONFIG_MACHINE_BSWAP_H List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nathan Froyd Cc: qemu-devel@nongnu.org Nathan Froyd wrote: > On Fri, Jul 24, 2009 at 08:30:22PM +0200, Juan Quintela wrote: >> @@ -176,7 +176,7 @@ VPATH+=:$(SRC_PATH)/linux-user:$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR) >> CPPFLAGS+=-I$(SRC_PATH)/linux-user -I$(SRC_PATH)/linux-user/$(TARGET_ABI_DIR) >> >> ifeq ($(ARCH),i386) >> -ifdef TARGET_GPROF >> +ifdef CONFIG_GPROF >> USE_I386_LD=y >> endif >> ifdef CONFIG_STATIC > > I don't see anything obviously wrong with the rest of the patch, but > this hunk and others make it look like you forgot to split out a patch > in your patch series. You are right. Nice catch. If Anthony asks for one split, will re-split. Later, Juan. PD. This is one of my few problems with git-rebase, when I am rebasing, something do a git commit --amend when it should be git rebase --continue And obviously, didn't catch this one.