Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Np87o-0000Qf-J8 for qemu-devel@nongnu.org; Tue, 09 Mar 2010 17:42:04 -0500 Received: from [199.232.76.173] (port=42578 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Np87o-0000QO-0d for qemu-devel@nongnu.org; Tue, 09 Mar 2010 17:42:04 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Np87m-0002WV-NX for qemu-devel@nongnu.org; Tue, 09 Mar 2010 17:42:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56844) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Np87m-0002WH-BT for qemu-devel@nongnu.org; Tue, 09 Mar 2010 17:42:02 -0500 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o29Mg1b4019881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Mar 2010 17:42:01 -0500 From: Juan Quintela In-Reply-To: <50a0e2ca9f4733a1ce896cb1da4a0d65c35d5882.1268173345.git.quintela@redhat.com> (Juan Quintela's message of "Tue, 9 Mar 2010 23:25:59 +0100") References: <50a0e2ca9f4733a1ce896cb1da4a0d65c35d5882.1268173345.git.quintela@redhat.com> Date: Tue, 09 Mar 2010 23:41:58 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 5/9] Introduce qemu_set_fd_rw_handler() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Juan Quintela wrote: > Patch consist: > diff --git a/aio.c b/aio.c > index f164a47..4185233 100644 > --- a/aio.c > +++ b/aio.c > @@ -93,7 +93,7 @@ int qemu_aio_set_fd_handler(int fd, > node->opaque = opaque; > } > > - qemu_set_fd_handler2(fd, NULL, io_read, io_write, opaque); > + qemu_set_fd_rw_handler(fd, io_read, io_write, opaque); > > return 0; > } NACK myself. Sorry, this one can't be changed, aio_set_fd_handler() is still called with NULL's. Sorry, please review rest. Later, Juan.