Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MeQCj-000087-KY for qemu-devel@nongnu.org; Fri, 21 Aug 2009 05:14:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MeQCe-0008SM-Ph for qemu-devel@nongnu.org; Fri, 21 Aug 2009 05:14:36 -0400 Received: from [199.232.76.173] (port=55072 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MeQCe-0008S7-4z for qemu-devel@nongnu.org; Fri, 21 Aug 2009 05:14:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48626) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MeQCd-0007rB-N2 for qemu-devel@nongnu.org; Fri, 21 Aug 2009 05:14:32 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7L9ESqG008338 for ; Fri, 21 Aug 2009 05:14:28 -0400 From: Juan Quintela In-Reply-To: <4A8E61D1.80003@redhat.com> (Gerd Hoffmann's message of "Fri, 21 Aug 2009 10:58:57 +0200") References: <4A8E61D1.80003@redhat.com> Date: Fri, 21 Aug 2009 11:12:14 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 00/23] New VMState table based load/save infrastructure List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann wrote: > On 08/20/09 19:42, Juan Quintela wrote: >> - i440fx_load() >> Can we put pci_irq_levels[] array in any struct? This is the only driver >> that I have found that uses a global variable. Gerd, can you take a look? >> It is not possible to have the PCIDevice struct inside a PIIXDevice or similar? > > Stuffing a pointer to pci_irq_levels into a struct should work without > problems and should be good enougth to get vmstate save/load going ;) > > Sticking the array itself into a struct would be even better, that > might need more cleanup work though. Do you mean to do any of the tow approachs? I promise to study your patch for other places that I need :) Later, Juan.