Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NsK9s-0000SL-VA for qemu-devel@nongnu.org; Thu, 18 Mar 2010 14:09:25 -0400 Received: from [199.232.76.173] (port=52237 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NsK9s-0000RN-80 for qemu-devel@nongnu.org; Thu, 18 Mar 2010 14:09:24 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NsK9q-0002y1-Ru for qemu-devel@nongnu.org; Thu, 18 Mar 2010 14:09:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10033) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NsK9q-0002xr-1E for qemu-devel@nongnu.org; Thu, 18 Mar 2010 14:09:22 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 5/6] error: Link qemu-img, qemu-nbd, qemu-io with qemu-error.o References: <1268848614-6844-1-git-send-email-armbru@redhat.com> <1268848614-6844-6-git-send-email-armbru@redhat.com> Date: Thu, 18 Mar 2010 19:09:16 +0100 In-Reply-To: (Blue Swirl's message of "Thu, 18 Mar 2010 19:58:00 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com Blue Swirl writes: > On 3/17/10, Markus Armbruster wrote: >> Blue Swirl writes: >> >> > On 3/17/10, Markus Armbruster wrote: [...] >> >> +void monitor_set_error(Monitor *mon, QError *qerror) >> >> +{ >> >> + assert(0); >> > >> > Please use abort(). >> >> >> Why? > > Because assert(0) does not abort when compiled with -DNDEBUG. Why is that a problem? And why isn't it a problem for the 300+ other assertions in the code?