Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NcjVG-0007aj-Ch for qemu-devel@nongnu.org; Wed, 03 Feb 2010 12:59:02 -0500 Received: from [199.232.76.173] (port=39264 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NcjVF-0007aW-S4 for qemu-devel@nongnu.org; Wed, 03 Feb 2010 12:59:01 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NcjVC-0005He-AO for qemu-devel@nongnu.org; Wed, 03 Feb 2010 12:59:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61114) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NcjVB-0005HW-Uk for qemu-devel@nongnu.org; Wed, 03 Feb 2010 12:58:58 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o13Hwt93020902 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 3 Feb 2010 12:58:55 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH] qcow2: Fix signedness bugs References: <1265120457-25143-1-git-send-email-kwolf@redhat.com> Date: Wed, 03 Feb 2010 18:58:50 +0100 In-Reply-To: <1265120457-25143-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Tue, 2 Feb 2010 15:20:57 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf writes: > Checking for return codes < 0 isn't really going to work with unsigned > types. Use signed types instead. Makes sense to me.