From: Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] give some useful error messages when tap open
References: <20100602143301.0289520c@redhat.com>
Date: Wed, 02 Jun 2010 20:26:58 +0200
In-Reply-To: <20100602143301.0289520c@redhat.com> (Luiz Capitulino's message
	of "Wed, 2 Jun 2010 14:33:01 -0300")
Message-ID: <m3r5kpp9xp.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: mjt@tls.msk.ru, qemu-devel@nongnu.org

Luiz Capitulino <lcapitulino@redhat.com> writes:

> From: Michael Tokarev <mjt@tls.msk.ru>
>
> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints
> (with fprintf) something like this:
>
>   warning: could not open /dev/net/tun: no virtual network emulation
>
> this has 2 issues:
>  1) it is not a warning really, it's a fatal error (kvm exits after
> that),
>  2) there's no indication as of what's actually wrong: printing errno there
>     is helpful.
>
> The patch below removes the "warning" prefix, uses %m (since it's linux,
> %m is available as format modifier), and changes fprintf() to %qemu_error().

To error_report(), you mean.

> Now it prints something like this instead:
>
>  could not configure /dev/net/tun: Device or resource busy
>
> (there are 2 messages like that in the same function)
>
> This fixes Debian bug #578154, see
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=578154
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>

Looks good.