Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9Ded-0007Qz-Fn for qemu-devel@nongnu.org; Tue, 04 May 2010 04:38:59 -0400 Received: from [140.186.70.92] (port=41030 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9Deb-0007QM-Rp for qemu-devel@nongnu.org; Tue, 04 May 2010 04:38:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9DeZ-0000pL-TL for qemu-devel@nongnu.org; Tue, 04 May 2010 04:38:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57652) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9DeZ-0000ow-J3 for qemu-devel@nongnu.org; Tue, 04 May 2010 04:38:55 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH] Revert "PCI: Convert pci_device_hot_add() to QObject" References: <20100426152137.34ee9fbe@redhat.com> <4BDF010B.6090007@codemonkey.ws> Date: Tue, 04 May 2010 10:38:51 +0200 In-Reply-To: <4BDF010B.6090007@codemonkey.ws> (Anthony Liguori's message of "Mon, 03 May 2010 11:59:55 -0500") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Luiz Capitulino Anthony Liguori writes: > On 05/03/2010 04:29 AM, Markus Armbruster wrote: [...] >> Why am I proposing to remove pci_add from QMP before its replacement is >> ready? I want it out sooner rather than later, because it isn't fully >> functional (errors and drive_add are missing), and we do not plan to >> complete the job. In other words, it's not really usable over QMP now, >> and it's not what we want for QMP anyway. Since we don't want it to be >> used over QMP, we should take it out, not leave it around as a trap for >> the uninitiated. >> >> Anyway, I'll respin with a more verbose commit message, and I'll throw >> in the buddy patch Revert "monitor: Convert do_pci_device_hot_remove() >> to QObject". >> > > Does libvirt not use pci_add with QMP? Re QMP in general: libvirt has code for QMP, but it is disabled. It'll get enabled as soon as a usable QMP ships, which we all expect for the next release. Re pci_add over QMP, git://libvirt.org/libvirt.git has: commit efd4ee7871a631a9293e94d58fc4384c162388a7 Author: Daniel P. Berrange Date: Wed Apr 14 15:23:38 2010 +0100 Remove code from JSON monitor for commands that won't be ported The QEMU developers have stated that they will not be porting the commands 'pci_add', 'pci_del', 'usb_add', 'usb_del' to the JSON mode monitor, since they're obsoleted by 'device_add' and 'device_del'. libvirt has (untested) code that would have supported those commands in theory, but since we already use device_add/del where available, there's no need to keep the legacy stuff anymore. The text mode monitor keeps support for all commands for sake of historical compatability. * src/qemu/qemu_monitor_json.c: Remove 'pci_add', 'pci_del', 'usb_add', 'usb_del' commands Does this answer your question?