Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mszgj-0002fO-Uw for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:57:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mszgf-0002ZG-56 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:57:49 -0400 Received: from [199.232.76.173] (port=43606 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mszge-0002Z7-Vq for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:57:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23823) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mszge-0006pB-BL for qemu-devel@nongnu.org; Wed, 30 Sep 2009 09:57:44 -0400 From: Juan Quintela In-Reply-To: (malc's message of "Wed, 30 Sep 2009 17:44:06 +0400 (MSD)") References: Date: Wed, 30 Sep 2009 15:57:18 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 27/49] ac97: add active to the state List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org malc wrote: > On Wed, 30 Sep 2009, Juan Quintela wrote: > >> malc wrote: >> >> >> There are more temporary variables in other devices, and this was the >> >> >> way it was done there. Normally I would have called it active_vmstate >> >> >> to make that explicit, but here, it was also used for reset, that is the >> >> >> way I named it with the _vmstate suffix. >> >> > >> >> > In any case the while i can understand the fear of malloc, nobody forces >> >> > you to do that you can have a scratch space on the stack, with an some >> >> > upper cap, that's the way it's done now anyhow, only the cap is stack size >> >> > reserved for the process and not something you have to choose. >> >> >> >> You call new way a monstrosity, and now propose a solution that makes >> >> the monster bigger? >> >> >> >> I still stand behind the patch, and I still want it applied. >> >> >> > >> > And it wont be, not this part of it, not in this state. >> >> Suggestions? Because you are not telling me that you expect to move >> something to the stack, reimplement alloca() and work from there was a >> _real suggestion_? >> > > Yet somehow you are explecting me to solve the problems with your design > for you, neat. Alloca can be used but is not strictly necessary. > > char buf[UPPER_CAP]; and maybe temp_fields that point to it and survive > the period between pre/post functions, would suffice, but anyhow, it's > your problem to solve, to reiterate i'm quite happy with what is there > now. No. Everywhere code changed as I changed in ac97. And everybody agrees. And now you told that everybody else was wrong, and that the only true way is changing everything else for a worse/uglier solution. As I told before, you have commit access, you win. Discussion is at the point: - you will accept _any_ solution that means not changing ac97. No compromises taken. - I will not make VMState worse/uglier/more complex just to work-around your veto. Patch don't goes in, you win and I have lost time porting ac97 to VMState. Later, Juan.