Received: from [140.186.70.92] (port=35148 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzRXK-0006r2-Hi for qemu-devel@nongnu.org; Sat, 25 Sep 2010 05:59:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzRXF-0004mv-Ey for qemu-devel@nongnu.org; Sat, 25 Sep 2010 05:59:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13090) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzRXF-0004mn-6W for qemu-devel@nongnu.org; Sat, 25 Sep 2010 05:59:13 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 8/8] [MIPS] qdev: convert rc4030 to sysbus device References: <1283978392-6313-1-git-send-email-hpoussin@reactos.org> <1283978392-6313-9-git-send-email-hpoussin@reactos.org> Date: Sat, 25 Sep 2010 11:59:09 +0200 In-Reply-To: (Blue Swirl's message of "Thu, 9 Sep 2010 14:37:50 +0000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: =?utf-8?Q?Herv=C3=A9?= Poussineau , qemu-devel@nongnu.org Blue Swirl writes: > 2010/9/8 Herv=C3=A9 Poussineau : >> Use it in Jazz emulation >> Remove rc4030_init() function, which is not used anymore >> >> Signed-off-by: Herv=C3=A9 Poussineau >> --- >> =C2=A0hw/mips.h =C2=A0 =C2=A0 =C2=A0| =C2=A0 =C2=A04 +- >> =C2=A0hw/mips_jazz.c | =C2=A0 =C2=A08 +-- >> =C2=A0hw/rc4030.c =C2=A0 =C2=A0| =C2=A0135 ++++++++++++++++++++++++++---= -------------------------- >> =C2=A03 files changed, 69 insertions(+), 78 deletions(-) >> >> diff --git a/hw/mips.h b/hw/mips.h >> index 2897ea6..bdbe024 100644 >> --- a/hw/mips.h >> +++ b/hw/mips.h >> @@ -16,8 +16,8 @@ typedef struct rc4030DMAState *rc4030_dma; >> =C2=A0void rc4030_dma_memory_rw(void *opaque, target_phys_addr_t addr, u= int8_t *buf, int len, int is_write); >> =C2=A0void rc4030_dma_read(void *dma, uint8_t *buf, int len); >> =C2=A0void rc4030_dma_write(void *dma, uint8_t *buf, int len); >> - >> -void *rc4030_init(qemu_irq timer, rc4030_dma **dmas); >> +extern rc4030_dma *rc4030_dmas; >> +extern void *rc4030_dma_opaque; > > These should be device properties (DEFINE_PROP_PTR, qdev_set_prop_ptr(). Note: DEFINE_PROP_PTR() & friends are for dirty hacks only. Maybe we should talk about how to do it cleanly. [...]