Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nwxpy-0000LE-DA for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:20:02 -0400 Received: from [140.186.70.92] (port=49237 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nwxpw-0008PB-2g for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:20:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nwxdw-0002Kd-TA for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:07:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57937) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nwxdw-0002KR-Ad for qemu-devel@nongnu.org; Wed, 31 Mar 2010 09:07:36 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2VD7Y9G031086 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 31 Mar 2010 09:07:34 -0400 From: Juan Quintela In-Reply-To: <1270039576-11968-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Wed, 31 Mar 2010 14:46:16 +0200") References: <1270039576-11968-1-git-send-email-kwolf@redhat.com> Date: Wed, 31 Mar 2010 15:07:32 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] Replace calls of old bdrv_open List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf wrote: > What is known today as bdrv_open2 becomes the new bdrv_open. All remaining > callers of the old function are converted to the new one. In some places they > even know the right format, so they should have used bdrv_open2 from the > beginning. > > Signed-off-by: Kevin Wolf I would preffer a: bdrv_open() like yours with assert(drv != NULL). bdrv_open_guess() for the current behaviour with NULL drv argument. Why? because I would like to have an easy way to grep for all places that "guess" what driver should they use. And as you found on the patch, several places knew it and where using it out of laziness. If I can have my pony, your patch is better than current behaviour :) Later, Juan.