Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NieU4-0006n4-Jm for qemu-devel@nongnu.org; Fri, 19 Feb 2010 20:50:16 -0500 Received: from [199.232.76.173] (port=43760 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NieU3-0006lo-T2 for qemu-devel@nongnu.org; Fri, 19 Feb 2010 20:50:15 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NieTt-0005F7-1l for qemu-devel@nongnu.org; Fri, 19 Feb 2010 20:50:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33728) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NieTs-0005F3-Lk for qemu-devel@nongnu.org; Fri, 19 Feb 2010 20:50:04 -0500 From: Juan Quintela In-Reply-To: <4B7EFEFA.60501@codemonkey.ws> (Anthony Liguori's message of "Fri, 19 Feb 2010 15:13:30 -0600") References: <1266250769-5816-1-git-send-email-kwolf@redhat.com> <4B7EFEFA.60501@codemonkey.ws> Date: Sat, 20 Feb 2010 02:49:17 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , armbru@redhat.com, qemu-devel@nongnu.org, gleb@redhat.com, hch@lst.de Anthony Liguori wrote: > On 02/15/2010 10:19 AM, Kevin Wolf wrote: >> The current implementation of alloc_refcount_block and grow_refcount_table has >> fundamental problems regarding error handling. There are some places where an >> I/O error means that the image is going to be corrupted. I have found that the >> only way to fix this is to completely rewrite the thing. >> >> Just sending as an RFC to the list hasn't generated a lot of comments (to be >> precise, not a single one). This is a critical part of qcow2 and needs reviews. >> So let's try it another way: People in CC, please give it a review. Sooner or >> later some of you will need to do so anyway. >> > > Should I apply this series? I still don't see any review comments. I sent review comments on the 18th. I expect Kevin to address them. I talked with him on irc while doing the review (i.e. he knows about them). Kevin??? Later, Juan.