Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjV4g-0005ZY-57 for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:59:34 -0500 Received: from [199.232.76.173] (port=50290 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjV4f-0005Z8-5Z for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:59:33 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjV4a-0003ow-Oi for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:59:32 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35617) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjV31-0003hh-Ru for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:59:28 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block References: <1266250769-5816-1-git-send-email-kwolf@redhat.com> <4B7EFEFA.60501@codemonkey.ws> <4B824645.3000505@redhat.com> Date: Mon, 22 Feb 2010 10:55:58 +0100 In-Reply-To: <4B824645.3000505@redhat.com> (Kevin Wolf's message of "Mon, 22 Feb 2010 09:54:29 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: hch@lst.de, qemu-devel@nongnu.org, gleb@redhat.com, Juan Quintela Kevin Wolf writes: > Am 20.02.2010 02:49, schrieb Juan Quintela: >> Anthony Liguori wrote: >>> On 02/15/2010 10:19 AM, Kevin Wolf wrote: >>>> The current implementation of alloc_refcount_block and grow_refcount_table has >>>> fundamental problems regarding error handling. There are some places where an >>>> I/O error means that the image is going to be corrupted. I have found that the >>>> only way to fix this is to completely rewrite the thing. >>>> >>>> Just sending as an RFC to the list hasn't generated a lot of comments (to be >>>> precise, not a single one). This is a critical part of qcow2 and needs reviews. >>>> So let's try it another way: People in CC, please give it a review. Sooner or >>>> later some of you will need to do so anyway. >>>> >>> >>> Should I apply this series? I still don't see any review comments. >> >> I sent review comments on the 18th. I expect Kevin to address them. I >> talked with him on irc while doing the review (i.e. he knows about >> them). > > I was hoping for more comments as there were three more people in the CC > list. But looks like they prefer reviewing the patches downstream. I'm > going to send a v2 which addresses only your comments if I don't get any > more comments soon. I don't prefer reviewing downstream at all, I just haven't been able to find the time for a review. Sorry.