Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NGAJf-0001yl-KQ for qemu-devel@nongnu.org; Thu, 03 Dec 2009 06:57:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NGAJa-0001qj-6a for qemu-devel@nongnu.org; Thu, 03 Dec 2009 06:57:46 -0500 Received: from [199.232.76.173] (port=57721 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NGAJZ-0001qQ-W8 for qemu-devel@nongnu.org; Thu, 03 Dec 2009 06:57:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42967) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NGAJZ-0006T1-Hi for qemu-devel@nongnu.org; Thu, 03 Dec 2009 06:57:41 -0500 From: Juan Quintela In-Reply-To: <20091203094836.GA6752@redhat.com> (Michael S. Tsirkin's message of "Thu, 3 Dec 2009 11:48:36 +0200") References: <20091202134153.GC18193@redhat.com> <20091202181911.GB3949@redhat.com> <20091202184410.GC3984@redhat.com> <20091203094836.GA6752@redhat.com> Date: Thu, 03 Dec 2009 12:56:57 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 06/41] virtio: Use DO_UPCAST instead of a cast List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org "Michael S. Tsirkin" wrote: > On Wed, Dec 02, 2009 at 08:03:22PM +0100, Juan Quintela wrote: >> "Michael S. Tsirkin" wrote: >> >> > I don't understand. >> > container_of is just more generic than DO_UPCAST. >> > So why *ever* use DO_UPCAST? Let's get rid of it. .... >> See how you create a device of size struct_size, but then you access it >> with vdev. If vdev is _not_ the 1st element of the struct, you have got >> corruption. > > A cleaner solution IMO would be to have callers allocate the memory > and pass VirtIODevice * to virtio_common_init. Been there, asked for that. Basically qdev + passing initialized memory = nono >> DO_UPCAST() prevent you for having that error. > > > If we want to assert specific structure layout, this > should be a compile-time check. There's no > reason to do this check every time at a random place where > DO_UPCAST is called. See DO_UPCAST() definition :) It is a compile time check. It just do cpp magic to be sure that things are right. DO_UPCAST() == (cast *) with some typechecking. >> container_of() would have leave you go around, and have a memory >> corruption not easy to fix. >> >> DO_UPCAST() macro was created just to avoid this kind of errors. >> >> Later, Juan.