Received: from [140.186.70.92] (port=56766 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OzRTw-0005hB-TJ for qemu-devel@nongnu.org; Sat, 25 Sep 2010 05:55:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OzRTs-0004LP-2R for qemu-devel@nongnu.org; Sat, 25 Sep 2010 05:55:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45017) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OzRTr-0004LC-R5 for qemu-devel@nongnu.org; Sat, 25 Sep 2010 05:55:44 -0400 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 3/8] [MIPS] qdev: convert jazz-led to sysbus device References: <1283978392-6313-1-git-send-email-hpoussin@reactos.org> <1283978392-6313-4-git-send-email-hpoussin@reactos.org> Date: Sat, 25 Sep 2010 11:55:41 +0200 In-Reply-To: <1283978392-6313-4-git-send-email-hpoussin@reactos.org> (=?utf-8?Q?=22Herv=C3=A9?= Poussineau"'s message of "Wed, 8 Sep 2010 22:39:47 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Herv=C3=A9?= Poussineau Cc: qemu-devel@nongnu.org Herv=C3=A9 Poussineau writes: > Use it in Jazz emulation > Remove jazz_led_init() function, which is not used anymore > Compile jazz_led.c file only once [...] > diff --git a/hw/jazz_led.c b/hw/jazz_led.c > index 4cb680c..f364301 100644 > --- a/hw/jazz_led.c > +++ b/hw/jazz_led.c [...] > @@ -70,30 +70,18 @@ static uint32_t led_readb(void *opaque, target_phys_a= ddr_t addr) > static uint32_t led_readw(void *opaque, target_phys_addr_t addr) > { > uint32_t v; > -#ifdef TARGET_WORDS_BIGENDIAN > - v =3D led_readb(opaque, addr) << 8; > - v |=3D led_readb(opaque, addr + 1); > -#else > v =3D led_readb(opaque, addr); > v |=3D led_readb(opaque, addr + 1) << 8; > -#endif > return v; > } Stupid question: why can you drop the #if here? [...]