Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NpKgz-0000A6-PY for qemu-devel@nongnu.org; Wed, 10 Mar 2010 07:07:13 -0500 Received: from [199.232.76.173] (port=38129 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NpKgz-00009q-4x for qemu-devel@nongnu.org; Wed, 10 Mar 2010 07:07:13 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NpKgx-00048R-W1 for qemu-devel@nongnu.org; Wed, 10 Mar 2010 07:07:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22479) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NpKgx-00048L-K8 for qemu-devel@nongnu.org; Wed, 10 Mar 2010 07:07:11 -0500 From: Juan Quintela In-Reply-To: (malc's message of "Wed, 10 Mar 2010 14:57:40 +0300 (MSK)") References: <4f197c437a4d2f813ce518b4fd2d86fc225f500e.1268214633.git.quintela@redhat.com> Date: Wed, 10 Mar 2010 13:06:54 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 01/14] Convert io handlers to QLIST List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org malc wrote: > On Wed, 10 Mar 2010, Juan Quintela wrote: >> - for(ioh = first_io_handler; ioh != NULL; ioh = ioh->next) { >> + QTAILQ_FOREACH(ioh, &io_handlers, next) { >> if (ioh->fd == fd) >> goto found; >> } >> ioh = qemu_mallocz(sizeof(IOHandlerRecord)); >> - ioh->next = first_io_handler; >> - first_io_handler = ioh; >> + QTAILQ_INSERT_TAIL(&io_handlers, ioh, next); > > The old code inserted at the head, didn't it? Sorry, you are right, it shouldn't matter too much, but it is a change. Later, Juan.