Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFuOW-0006lY-P0 for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:57:44 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFuOS-0006gH-Pg for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:57:44 -0500 Received: from [199.232.76.173] (port=37084 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFuOS-0006fx-IF for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:57:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9929) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFuOR-0008IK-PJ for qemu-devel@nongnu.org; Wed, 02 Dec 2009 13:57:40 -0500 From: Juan Quintela In-Reply-To: <20091202173823.GA3638@redhat.com> (Michael S. Tsirkin's message of "Wed, 2 Dec 2009 19:38:23 +0200") References: <1971390dc6d0ae9014e796f8ee444dee4a90815a.1259754427.git.quintela@redhat.com> <20091202173823.GA3638@redhat.com> Date: Wed, 02 Dec 2009 19:56:58 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 38/41] virtio-blk: use QLIST for the list of requests List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org "Michael S. Tsirkin" wrote: > On Wed, Dec 02, 2009 at 01:04:36PM +0100, Juan Quintela wrote: >> viltio_blak_dma_restart_bh() was unsafe, it used req->next after having >> (possible) put req in another list >> >> Signed-off-by: Juan Quintela > > Sounds good, but why is this part of vmstate patchset? Rest of the patches depend on it. I tried to only do the cleanups needed for vmstate. I really forced me to not doing more cleanups. Later, Juan.