Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFPJ2-0000pV-HK for qemu-devel@nongnu.org; Tue, 01 Dec 2009 04:46:00 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFPIx-0000n3-Uw for qemu-devel@nongnu.org; Tue, 01 Dec 2009 04:46:00 -0500 Received: from [199.232.76.173] (port=57629 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFPIx-0000mv-Gs for qemu-devel@nongnu.org; Tue, 01 Dec 2009 04:45:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29260) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFPIx-00010X-64 for qemu-devel@nongnu.org; Tue, 01 Dec 2009 04:45:55 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB19jsKg001414 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Dec 2009 04:45:54 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH v2] qcow2: Store exact backing format length References: <1259240622-13469-1-git-send-email-kwolf@redhat.com> Date: Tue, 01 Dec 2009 10:45:52 +0100 In-Reply-To: <1259240622-13469-1-git-send-email-kwolf@redhat.com> (Kevin Wolf's message of "Thu, 26 Nov 2009 14:03:42 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf writes: > Currently qcow2 unnecessarily rounds up the length of the backing format string > to the next multiple of 8. At the same time, the array in BlockDriverState can > only hold 15 characters, so in effect backing formats with 9 characters or more > don't work (e.g. host_device). > > Save the real string length and things start to work for all valid image format > names. > > Signed-off-by: Kevin Wolf Looks good to me. > --- > > v2: > - Don't rely on sizeof(ext) being a multiple of 8 Broken before your patch, so this is bonus fix.