Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1My9XN-0005Au-3O for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:29:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1My9XI-00050L-0U for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:29:28 -0400 Received: from [199.232.76.173] (port=49974 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1My9XH-0004zz-R6 for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:29:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38505) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1My9XG-0003Yf-Bm for qemu-devel@nongnu.org; Wed, 14 Oct 2009 15:29:22 -0400 From: Juan Quintela In-Reply-To: (andrzej zaborowski's message of "Wed, 14 Oct 2009 20:15:23 +0200") References: Date: Wed, 14 Oct 2009 21:28:54 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] Re: [PATCH 12/16] vmware_vga: remove !EMBED_STDVGA code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: andrzej zaborowski Cc: qemu-devel@nongnu.org andrzej zaborowski wrote: > 2009/10/14 Juan Quintela : >> It don't compile. =C2=A0And the trivial fixes (change vga.foo field to f= oo field >> don't work either. =C2=A0No output > > Just a note that there's supposed to be no output because your guest > OS (and BIOS) expect the standard VGA functionality to be there. The > define is only useful for debugging vmware_vga or OS driver. It's ok > to drop it if you want. I preffer to drop it because it has no chance of working (suspend/resume code is not there for instance). Once that we are there. I did a fast try at enabling DIRECT_VRAM with the same not working result. Any idea if it would make things better/fast/... whatever? The reason that I ask is because the driver is smaller than cirrus_vga, and it supports already lots of resolutions. Later, Juan.