Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mt2Xi-0007jG-V6 for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:00:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mt2Xc-0007ZY-7R for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:00:40 -0400 Received: from [199.232.76.173] (port=43058 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mt2Xb-0007ZC-SL for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:00:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54656) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mt2Xb-0004HS-Bf for qemu-devel@nongnu.org; Wed, 30 Sep 2009 13:00:35 -0400 From: Juan Quintela In-Reply-To: <20090930135142.GA20378@redhat.com> (Michael S. Tsirkin's message of "Wed, 30 Sep 2009 15:51:42 +0200") References: <20090923200635.GA21246@redhat.com> <20090924191121.GB29419@redhat.com> <20090929161115.GA13885@redhat.com> <20090930135142.GA20378@redhat.com> Date: Wed, 30 Sep 2009 19:00:21 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: CODING_STYLE List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Blue Swirl , qemu-devel@nongnu.org "Michael S. Tsirkin" wrote: .... >> Actually, I tried to tweak 'indent' to match QEMU style without much success. >> >> We could also select a new style, like Linux kernel one. I'm also not >> a great fan of that either. But at least 'indent' could be used very >> easily and I think there would be other benefits, like reuse of Git >> hooks, patch checking scripts and Emacs configs. With full 'indent' >> support all sources could be massaged mechanically to make the switch >> less painful. >> >> Then there are K&R and GNU styles, but I like them even less. > > So ... Linux kernel style wins? What do others think? Where do I have to sign? I very much prefer Linux kernel style, but that is a preference. Having an style that indent understands is a great idea, as it makes trivial to make sure that you are not going againsnt CodingStyle. Bigger advantage of Linux Kernel one is the infrastructure/hooks already again. Later, Juan. PD. I am also in the team that dislikes K&R and GNU (speciall GNU). >From linux-2.6/Documentation/CodingStyle Linux kernel coding style ..... First off, I'd suggest printing out a copy of the GNU coding standards, and NOT read it. Burn them, it's a great symbolic gesture.