Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NjUwb-00044L-NN for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:51:13 -0500 Received: from [199.232.76.173] (port=42672 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NjUwZ-00043Z-SG for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:51:11 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NjUwY-0003W9-LU for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:51:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53248) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NjUwY-0003Vu-8C for qemu-devel@nongnu.org; Mon, 22 Feb 2010 04:51:10 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1M9p9I2005841 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 22 Feb 2010 04:51:09 -0500 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH] fix 'i' format handling in memory dump References: <20100221142320.GP14767@redhat.com> Date: Mon, 22 Feb 2010 10:51:06 +0100 In-Reply-To: <20100221142320.GP14767@redhat.com> (Gleb Natapov's message of "Sun, 21 Feb 2010 16:23:20 +0200") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org Gleb Natapov writes: > It was broken by 09b9418c6d0. (!env && !is_physical) != (!is_physical) > when env is true. > > Signed-off-by: Gleb Natapov > diff --git a/monitor.c b/monitor.c > index b1a6edc..19470d1 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1297,8 +1297,6 @@ static void memory_dump(Monitor *mon, int count, int format, int wsize, > int flags; > flags = 0; > env = mon_get_cpu(); > - if (!is_physical) > - return; > #ifdef TARGET_I386 > if (wsize == 2) { > flags = 1; *Ouch* I checked the offending commit for more such errors, but couldn't find any.