Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NFYLp-0005Fs-IK for qemu-devel@nongnu.org; Tue, 01 Dec 2009 14:25:29 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NFYLk-0005DM-OX for qemu-devel@nongnu.org; Tue, 01 Dec 2009 14:25:28 -0500 Received: from [199.232.76.173] (port=38810 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NFYLk-0005DG-Ex for qemu-devel@nongnu.org; Tue, 01 Dec 2009 14:25:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8675) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NFYLk-0006VN-6D for qemu-devel@nongnu.org; Tue, 01 Dec 2009 14:25:24 -0500 From: Juan Quintela In-Reply-To: <4B1567B7.60107@siemens.com> (Jan Kiszka's message of "Tue, 01 Dec 2009 20:00:07 +0100") References: <4B1567B7.60107@siemens.com> Date: Tue, 01 Dec 2009 20:24:38 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH] vmstate: Fix info field of VMSTATE_MACADDR List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Anthony Liguori , qemu-devel , Liran Schour , Pierre Riteau Jan Kiszka wrote: > Signed-off-by: Jan Kiszka > --- > > This may partly or fully explain the e1000 issue Pierre reported first. > However, there are more bugs in the current migration code, e.g. in > qemu_fseek when used with streams, it still doesn't work properly here. > Need a break... You arrived at the same conclussion than me :( > hw/hw.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/hw.h b/hw/hw.h > index 86ee716..dc119f0 100644 > --- a/hw/hw.h > +++ b/hw/hw.h > @@ -546,7 +546,7 @@ extern const VMStateDescription vmstate_i2c_slave; > #define VMSTATE_MACADDR(_field, _state) { \ > .name = (stringify(_field)), \ > .size = sizeof(MACAddr), \ > - .info = &vmstate_info_uint8, \ > + .info = &vmstate_info_buffer, \ > .flags = VMS_BUFFER, \ > .offset = vmstate_offset_macaddr(_state, _field), \ > } Good catch. Later, Juan.