Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MltBp-00076l-9E for qemu-devel@nongnu.org; Thu, 10 Sep 2009 19:36:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MltBk-00071P-9V for qemu-devel@nongnu.org; Thu, 10 Sep 2009 19:36:32 -0400 Received: from [199.232.76.173] (port=45250 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MltBk-00071M-5r for qemu-devel@nongnu.org; Thu, 10 Sep 2009 19:36:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1584) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MltBj-0003VP-Nh for qemu-devel@nongnu.org; Thu, 10 Sep 2009 19:36:28 -0400 From: Juan Quintela In-Reply-To: (malc's message of "Fri, 11 Sep 2009 03:10:59 +0400 (MSD)") References: <4AA939B3.6000103@codemonkey.ws> <4AA978DB.90301@codemonkey.ws> Date: Fri, 11 Sep 2009 01:33:31 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: [Qemu-devel] Re: [PATCH 05/26] Unexport ticks_per_sec variable. Create get_ticks_per_sec() function List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-devel@nongnu.org malc wrote: > On Thu, 10 Sep 2009, Anthony Liguori wrote: > >> malc wrote: >> > On Thu, 10 Sep 2009, Anthony Liguori wrote: >> > >> > >> > > malc wrote: >> > > >> > > > My problem with this patch is that it is completely pointless, touches >> > > > a gob of places and the fact that you apparently never seen what a >> > > > function call entails on PPC64 (any ABI). >> > > > >> > > But there is nothing to suggest this variable is every in the fast path so >> > > any overhead argument is unfounded. >> > > >> > > More importantly, using a function to access this variable gives us the >> > > ability to change how the behavior is implemented without touching a gob >> > > of >> > > places. >> > > >> > > >> > >> > Untill such an ability is needed, the patch adds nothing, >> >> Except that it eliminates the possibility of misusing the interface and >> setting it somewhere it shouldn't be. >> >> It makes the code more defensive because you cannot accidentally use it like >> it's a local variable. The key bit of the patch is: >> >> -int64_t ticks_per_sec; >> +static int64_t ticks_per_sec; >> >> >> That is *always* a worthwhile change to make. We need more patches like this. >> > > And generalizations are always true. So? > Anyhow, i'm explicitly against the > patch, so first obtain the express acknowledgment from the leaders, > otherwise i'll revert it should it go in. Now playing the commit access card. At this point I retire for the discussion, as clearly I am not one of the leaders to revert your revert back. Later, Juan.