Received: from eggs.gnu.org ([208.118.235.92]:60010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPafy-0001mo-1l for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:41:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPafv-0002yE-51 for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:41:37 -0400 Received: from cantor2.suse.de ([195.135.220.15]:34300 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPafu-0002xu-Ul for qemu-devel@nongnu.org; Tue, 09 Apr 2013 11:41:35 -0400 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2018AA3CEE for ; Tue, 9 Apr 2013 17:41:34 +0200 (CEST) From: Andreas Schwab Date: Tue, 09 Apr 2013 17:41:33 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Subject: [Qemu-devel] [PATCH] linux-user: fix setgroups/getgroups for non-UID16 archs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Don't assume target_id is a short. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index d3c26de..3f13d0b 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7800,12 +7800,12 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, if (gidsetsize == 0) break; if (!is_error(ret)) { - target_grouplist = lock_user(VERIFY_WRITE, arg2, gidsetsize * 2, 0); + target_grouplist = lock_user(VERIFY_WRITE, arg2, gidsetsize * sizeof(target_id), 0); if (!target_grouplist) goto efault; for(i = 0;i < ret; i++) target_grouplist[i] = tswapid(high2lowgid(grouplist[i])); - unlock_user(target_grouplist, arg2, gidsetsize * 2); + unlock_user(target_grouplist, arg2, gidsetsize * sizeof(target_id)); } } break; @@ -7817,7 +7817,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, int i; if (gidsetsize) { grouplist = alloca(gidsetsize * sizeof(gid_t)); - target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * 2, 1); + target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * sizeof(target_id), 1); if (!target_grouplist) { ret = -TARGET_EFAULT; goto fail; -- 1.8.2.1 -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."