From: "Michal Wajdeczko" Subject: Re: [PATCH v13 19/21] drm/i915/guc: Fix enable/disable of GuC GGTT invalidate functions Date: Wed, 11 Oct 2017 20:20:27 +0200 Message-ID: References: <1507712056-25030-1-git-send-email-sagar.a.kamble@intel.com> <1507712056-25030-20-git-send-email-sagar.a.kamble@intel.com> <8b97cb9f-8a24-be97-2987-47fe9068088b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80A766E1C3 for ; Wed, 11 Oct 2017 18:20:30 +0000 (UTC) In-Reply-To: <8b97cb9f-8a24-be97-2987-47fe9068088b@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Sagar Arun Kamble List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxMSBPY3QgMjAxNyAyMDowOToxMCArMDIwMCwgU2FnYXIgQXJ1biBLYW1ibGUgIAo8 c2FnYXIuYS5rYW1ibGVAaW50ZWwuY29tPiB3cm90ZToKCj4KPgo+IE9uIDEwLzExLzIwMTcgMTE6 MjggUE0sIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6Cj4+IE9uIFdlZCwgMTEgT2N0IDIwMTcgMTk6 NDQ6MzEgKzAyMDAsIFNhZ2FyIEFydW4gS2FtYmxlICAKPj4gPHNhZ2FyLmEua2FtYmxlQGludGVs LmNvbT4gd3JvdGU6Cj4+Cj4+Pgo+Pj4KPj4+IE9uIDEwLzExLzIwMTcgMTE6MDUgUE0sIE1pY2hh bCBXYWpkZWN6a28gd3JvdGU6Cj4+Pj4gT24gV2VkLCAxMSBPY3QgMjAxNyAxMDo1NDoxNCArMDIw MCwgU2FnYXIgQXJ1biBLYW1ibGUgIAo+Pj4+IDxzYWdhci5hLmthbWJsZUBpbnRlbC5jb20+IHdy b3RlOgo+Pj4+Cj4+Pj4+IGk5MTVfZ2d0dF9lbmFibGVfZ3VjIGhhcyB0byBoYXBwZW4gZmlyc3Qg ZHVyaW5nIGk5MTVfZ2VtX3Jlc3VtZQo+Pj4+PiBpZiBHdUMgbG9hZGluZyBpcyBlbmFibGVkIGJl Zm9yZSBHVFQgcmVzdG9yZS4gSW4gY2FzZSBHdUMgaXMgbm90Cj4+Pj4+IGxvYWRlZCB0aGlzIGVu YWJsaW5nIGhhcHBlbmluZyBkdXJpbmcgaW50ZWxfdWNfaW5pdF9odyBuZWVkIHRvCj4+Pj4+IHNr aXBwZWQuIChhdm9pZCB0aGUgR0VNX0JVR19PTikKPj4+Pj4gaTkxNV9nZ3R0X2Rpc2FibGVfZ3Vj IGF0IHRoZSBlbmQgb2YgcmVzZXQvc3VzcGVuZC91bmxvYWQgaXMgbmVlZGVkCj4+Pj4+IHBvc3Qg R0dUVCBzdXNwZW5kIG9wZXJhdGlvbnMuIENhbGxpbmcgaXQgZHVyaW5nIHVjX3Nhbml0aXplIGNv dmVycwo+Pj4+PiBhbGwgc2NlbmFyaW9zLiBIZW5jZSwgaXQgaXMgcmVtb3ZlZCBmcm9tIGludGVs X3VjX2ZpbmlfaHcuIEFsc28gdGhlc2UKPj4+Pj4gbmVlZHRvIGJlIHByb3RlY3RlZCBieSBzdHJ1 Y3RfbXV0ZXguIEhlbmNlIHN0cnVjdF9tdXRleCBsb2NraW5nIGlzCj4+Pj4+IGFkZGVkIGluIGk5 MTVfZ2VtX3Nhbml0aXplIHdoaWxlIHNhbml0aXppbmcgdUMuIHN0cnVjdF9tdXRleCBpcyAgCj4+ Pj4+IGFscmVhZHkKPj4+Pj4gaGVsZCBkdXJpbmcgaTkxNV9nZW1fcmVzZXRfcHJlcGFyZS4KPj4+ Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogU2FnYXIgQXJ1biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxl QGludGVsLmNvbT4KPj4+Pj4gQ2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpkZWN6a29A aW50ZWwuY29tPgo+Pj4+PiBDYzogTWljaGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lA aW50ZWwuY29tPgo+Pj4+PiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+Cj4+Pj4+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+Cj4+Pj4+IC0tLQo+Pj4+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8 ICA0ICsrKysKPj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgfCAxNiArKysr KysrKysrKy0tLS0tCj4+Pj4+ICAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKyksIDUg ZGVsZXRpb25zKC0pCj4+Pj4+Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jICAKPj4+Pj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4+ Pj4+IGluZGV4IGE0YmJmNmMuLjc3YTA3NDYgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9nZW0uYwo+Pj4+PiBAQCAtNDc1OSw2ICs0NzU5LDEwIEBAIHZvaWQgaTkxNV9nZW1fcmVzdW1l KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICAKPj4+Pj4gKmRldl9wcml2KQo+Pj4+PiAgICAgIFdB Uk5fT04oZGV2X3ByaXYtPmd0LmF3YWtlKTsKPj4+Pj4gICAgIG11dGV4X2xvY2soJmRldi0+c3Ry dWN0X211dGV4KTsKPj4+Pj4gKyAgICAvKiBXZSBuZWVkIHRvIG5vdGlmeSB0aGUgZ3VjIHdoZW5l dmVyIHdlIGNoYW5nZSB0aGUgR0dUVCAqLwo+Pj4+PiArICAgIGlmIChpOTE1X21vZHBhcmFtcy5l bmFibGVfZ3VjX2xvYWRpbmcpCj4+Pj4+ICsgICAgICAgIGk5MTVfZ2d0dF9lbmFibGVfZ3VjKGRl dl9wcml2KTsKPj4+Pj4gKwo+Pj4+PiAgICAgIGk5MTVfZ2VtX3Jlc3RvcmVfZ3R0X21hcHBpbmdz KGRldl9wcml2KTsKPj4+Pj4gICAgICBpOTE1X2dlbV9yZXN0b3JlX2ZlbmNlcyhkZXZfcHJpdik7 Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jICAKPj4+ Pj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4+Pj4+IGluZGV4IDkwMTBhYjUu LjBiNzk5ZmUgMTAwNjQ0Cj4+Pj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Vj LmMKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+Pj4+PiBAQCAt MTg0LDggKzE4NCwxNCBAQCBpbnQgaW50ZWxfdWNfaW5pdF9odyhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAgCj4+Pj4+ICpkZXZfcHJpdikKPj4+Pj4gICAgICBndWNfZGlzYWJsZV9jb21tdW5pY2F0 aW9uKGd1Yyk7Cj4+Pj4+ICAgICAgZ2VuOV9yZXNldF9ndWNfaW50ZXJydXB0cyhkZXZfcHJpdik7 Cj4+Pj4+IC0gICAgLyogV2UgbmVlZCB0byBub3RpZnkgdGhlIGd1YyB3aGVuZXZlciB3ZSBjaGFu Z2UgdGhlIEdHVFQgKi8KPj4+Pj4gLSAgICBpOTE1X2dndHRfZW5hYmxlX2d1YyhkZXZfcHJpdik7 Cj4+Pj4+ICsgICAgLyoKPj4+Pj4gKyAgICAgKiBXZSBuZWVkIHRvIG5vdGlmeSB0aGUgZ3VjIHdo ZW5ldmVyIHdlIGNoYW5nZSB0aGUgR0dUVC4KPj4+Pj4gKyAgICAgKiBEdXJpbmcgcmVzdW1lIGZy b20gc2xlZXAgd2Ugd291bGQgaGF2ZSBhbHJlYWR5IHVwZGF0ZWQgdGhlCj4+Pj4+ICsgICAgICog R0dUVCBpbnZhbGlkYXRlIGZ1bmN0aW9uIGZvciBHdUMgZHVyaW5nIGk5MTVfZ2VtX3Jlc3VtZSBz bwo+Pj4+PiArICAgICAqIHdlIG5lZWQgdG8gc2tpcCBoZXJlLiBXaWxsIGVuYWJsZSBoZXJlIG9u IGRyaXZlciBsb2FkL3Jlc2V0Lgo+Pj4+PiArICAgICAqLwo+Pj4+PiArICAgIGlmICghZ3VjLT5z dXNwZW5kZWQpCj4+Pj4+ICsgICAgICAgIGk5MTVfZ2d0dF9lbmFibGVfZ3VjKGRldl9wcml2KTsK Pj4+Pj4gICAgIGlmIChpOTE1X21vZHBhcmFtcy5lbmFibGVfZ3VjX3N1Ym1pc3Npb24pIHsKPj4+ Pj4gICAgICAgICAgLyoKPj4+Pj4gQEAgLTMwOSw5ICszMTUsNiBAQCB2b2lkIGludGVsX3VjX2Ns ZWFudXAoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgIAo+Pj4+PiAqZGV2X3ByaXYpCj4+Pj4+ICAg ICAgZ3VjX2ZyZWVfbG9hZF9lcnJfbG9nKGd1Yyk7Cj4+Pj4+ICAgICBpOTE1X2d1Y19zdWJtaXNz aW9uX2NsZWFudXAoZGV2X3ByaXYpOwo+Pj4+PiAtCj4+Pj4+IC0gICAgaWYgKGk5MTVfbW9kcGFy YW1zLmVuYWJsZV9ndWNfbG9hZGluZykKPj4+Pj4gLSAgICAgICAgaTkxNV9nZ3R0X2Rpc2FibGVf Z3VjKGRldl9wcml2KTsKPj4+Pj4gIH0KPj4+Pj4gLyoqCj4+Pj4+IEBAIC00NTIsNiArNDU1LDkg QEAgdm9pZCBpbnRlbF91Y19zYW5pdGl6ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAgCj4+Pj4+ ICpkZXZfcHJpdikKPj4+Pj4gICAgICBzdHJ1Y3QgaW50ZWxfdWNfZncgKmh1Y19mdyA9ICZkZXZf cHJpdi0+aHVjLmZ3Owo+Pj4+PiAgICAgaWYgKGk5MTVfbW9kcGFyYW1zLmVuYWJsZV9ndWNfbG9h ZGluZykgewo+Pj4+PiArICAgICAgICBpZiAoZ3VjX2Z3LT5sb2FkX3N0YXR1cyA9PSBJTlRFTF9V Q19GSVJNV0FSRV9TVUNDRVNTKQo+Pj4+Cj4+Pj4gSG1tLCBpc24ndCB0aGF0IGNoZWNrIHJlZHVu ZGFudCA/Cj4+PiB1Y19zYW5pdGl6ZSBjYW4gaGFwcGVuIHdpdGhvdXQgZmlybXdhcmUgbG9hZGVk IHRvbyBpbiB3aGljaCBjYXNlIHdlCj4+Cj4+IElmIHVjX3Nhbml0aXplIGNhbiBiZSBsb2FkZWQg d2l0aG91dCBmaXJtd2FyZSBsb2FkZWQsIHRoZW4gSSBhc3N1bWUKPj4gaTkxNV9tb2RwYXJhbXMu ZW5hYmxlX2d1Y19sb2FkaW5nIHdpbGwgYmUgY2xlYXJlZCB0b28sIHJpZ2h0ID8KPj4KPj4gSSdt IGp1c3Qgd29uZGVyaW5nIGlmIHdlIG5lZWQgdG8gY2hlY2sgYm90aCBtb2RwYXJhbSBhbmQgZncg c3RhdHVzLgo+IGFjdHVhbGx5IGxvYWQgdGltZSB1Y19zYW5pdGl6ZSBpcyBoYXBwZW5pbmcgYmVm b3JlIHVjX3Nhbml0aXplX29wdGlvbnMKCkhtbSwgc28gbWF5YmUgd2Ugc2hvdWxkIGNhbGwgaW50 ZWxfc2FuaXRpemVfb3B0aW9ucygpIGZyb20gb3IgcmlnaHQgYWZ0ZXIKaTkxNV9kcml2ZXJfaW5p dF9lYXJseSgpID8gSXQgbG9va3MgdGhhdCBhbGwgJ3Nhbml0aXplLW9wdGlvbnMnIGFyZSB1c2lu Zwpvbmx5IGRldmljZSBpbmZvIGZsYWdzLCB0aGVyZSBpcyBubyBNTUlPIGFjY2Vzcy4gQ2hyaXMv Sm9vbmFzPwoKCj4gc28gZW5hYmxlX2d1Y19sb2FkaW5nIHdpbGwgaGF2ZQo+IG5vbi16ZXJvIHZh bHVlIGZvciBzb21lIHBsYXRmb3Jtcy4gU28gIEkgdGhpbmsgaXQgbWFrZXMgc2Vuc2UgdG8gbGlt aXQgIAo+IHRoaXMgdG8gb25seSBsb2FkX3N0YXR1cyBiYXNlZC4KPj4KPj4+IGRvbid0IHdhbnQg dG8gZ2d0dF9kaXNhYmxlX2d1Yy4KPj4+IGlmIHdlIHdhbnQgdG8gZ2d0dF9kaXNhYmxlX2d1YyB0 aGVuIHdlIHNob3VsZCByZW1vdmUgdGhlIEdFTV9CVUdfT04gaW4gIAo+Pj4gaXQuCj4+Cj4+IEht bSwgdGhpcyBpcyB0aGUgd2F5IGhvdyB3ZSBydW4gQ0kgdGVzdHMgOykKPiB5ZXMgLi4uIGZyb20g bG9uZyB0aW1lIDopCj4+Cj4+Pj4KPj4+Pj4gKyBpOTE1X2dndHRfZGlzYWJsZV9ndWMoZGV2X3By aXYpOwo+Pj4+PiArCj4+Pj4+ICAgICAgICAgIGd1Y19mdy0+bG9hZF9zdGF0dXMgPSBJTlRFTF9V Q19GSVJNV0FSRV9OT05FOwo+Pj4+PiAgICAgICAgICBodWNfZnctPmxvYWRfc3RhdHVzID0gSU5U RUxfVUNfRklSTVdBUkVfTk9ORTsKPj4+Pj4gICAgICB9Cj4+Pj4KPj4+PiBCdHcsIHdoYXQgc2hv dWxkIHdlIGRvIHdpdGggInN1c3BlbmRlZCIgZmxhZyBkdXJpbmcgc2FuaXRpemUgPwo+Pj4gc3Vz cGVuZGVkIGZsYWcgaXMgc2V0IHRvIHRydWUgb24gc3VzcGVuZCBhbmQgZmFsc2Ugb24gcmVzdW1l Lgo+Pj4gc2FuaXRpemUgaXMgZG9uZSBwb3N0IHN1c3BlbmQgYW5kIGJlZm9yZSByZXN1bWUgc28g d2Ugc2hvdWxkIG5vdCB0b3VjaCAgCj4+PiBpdC4KPj4+IGluaXRpYWxpemluZyBpdCB0byBmYWxz ZSBkdXJpbmcgZ3VjX2luaXRfZWFybHkgc2hvdWxkIHRha2UgY2FyZSBvZiAgCj4+PiByZWxvYWQg KGR1cmluZyB1bmxvYWQgd2UgYXJlIHN1c3BlbmRpbmcgZ2VtIGJ1dCB3ZSB3b250IHJlc3VtZSkK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==