From: "Michal Wajdeczko" Subject: Re: [PATCH v4 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes Date: Thu, 19 Apr 2018 17:45:39 +0200 Message-ID: References: <1524070894-8120-1-git-send-email-yaodong.li@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4E988991C for ; Thu, 19 Apr 2018 15:45:43 +0000 (UTC) In-Reply-To: <1524070894-8120-1-git-send-email-yaodong.li@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, Jackie Li List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAxOCBBcHIgMjAxOCAxOTowMTozMSArMDIwMCwgSmFja2llIExpIDx5YW9kb25nLmxp QGludGVsLmNvbT4gd3JvdGU6Cgo+IEFmdGVyIGVuYWJsZWQgdGhlIFdPUENNIHdyaXRlLW9uY2Ug cmVnaXN0ZXJzIGxvY2tpbmcgc3RhdHVzIGNoZWNraW5nLAo+IHJlbG9hZGluZyBvZiB0aGUgaTkx NSBtb2R1bGUgd2lsbCBmYWlsIHdpdGggbW9kcGFyYW0gZW5hYmxlX2d1YyBzZXQgdG8gMwo+IChl bmFibGUgR3VDIGFuZCBIdUMgZmlybXdhcmUgbG9hZGluZykgaWYgdGhlIG1vZHVsZSB3YXMgb3Jp Z2luYWxseSBsb2FkZWQKPiB3aXRoIGVuYWJsZV9ndWMgc2V0IHRvIDEgKG9ubHkgZW5hYmxlIEd1 QyBmaXJtd2FyZSBsb2FkaW5nKS4gVGhpcyBpcwo+IGJlY2F1c2UgV09QQ00gcmVnaXN0ZXJzIHdl cmUgdXBkYXRlZCBhbmQgbG9ja2VkIHdpdGhvdXQgY29uc2lkZXJpbmcgdGhlICAKPiBIdUMKPiBG VyBzaXplLiBTaW5jZSB3ZSBuZWVkIGJvdGggR3VDIGFuZCBIdUMgRlcgc2l6ZXMgdG8gZGV0ZXJt aW5lIHRoZSBmaW5hbAo+IGxheW91dCBvZiBXT1BDTSwgd2Ugc2hvdWxkIGFsd2F5cyBjYWxjdWxh dGUgdGhlIFdPUENNIGxheW91dCBiYXNlZCBvbiB0aGUKPiBhY3R1YWwgc2l6ZXMgb2YgdGhlIEd1 QyBhbmQgSHVDIGZpcm13YXJlIGF2YWlsYWJsZSBmb3IgYSBzcGVjaWZpYyAgCj4gcGxhdGZvcm0K PiBpZiB3ZSBuZWVkIGNvbnRpbnVlIHRvIHN1cHBvcnQgZW5hYmxlL2Rpc2FibGUgSHVDIEZXIGxv YWRpbmcgZHluYW1pY2FsbHkKPiB3aXRoIGVuYWJsZV9ndWMgbW9kcGFyYW0uCj4KPiBUaGlzIHBh dGNoIHNwbGl0cyB1QyBmaXJtd2FyZSBmZXRjaGluZyBpbnRvIHR3byBzdGFnZXMuIEZpcnN0IHN0 YWdlIGlzIHRvCj4gZmV0Y2ggdGhlIGZpcm13YXJlIGltYWdlIGFuZCB2ZXJpZnkgdGhlIGZpcm13 YXJlIGhlYWRlci4gdUMgZmlybXdhcmUgd2lsbAo+IGJlIG1hcmtlZCBhcyB2ZXJpZmllZCBhbmQg dGhpcyB3aWxsIG1ha2UgRlcgaW5mbyBhdmFpbGFibGUgZm9yIGZvbGxvd2luZwo+IFdPUENNIGxh eW91dCBjYWxjdWxhdGlvbi4gVGhlIHNlY29uZCBzdGFnZSBpcyB0byBjcmVhdGUgYSBHRU0gb2Jq ZWN0IGFuZAo+IGNvcHkgdGhlIEZXIGRhdGEgaW50byB0aGUgY3JlYXRlZCBHRU0gb2JqZWN0IHdo aWNoIHdpbGwgb25seSBiZSBhdmFpbGFibGUKPiB3aGVuIEd1Qy9IdUMgbG9hZGluZyBpcyBlbmFi bGVkIGJ5IGVuYWJsZV9ndWMgbW9kcGFyYW0uIFRoaXMgd2lsbCAgCj4gZ3VhcmFudGVlCj4gdGhh dCB0aGUgV09QQ00gbGF5b3V0IHdpbGwgYmUgYWx3YXlzIGJlIGNhbGN1bGF0ZWQgY29ycmVjdGx5 IHdpdGhvdXQgIAo+IG1ha2luZwo+IGFueSBhc3N1bXB0aW9ucyB0byB0aGUgR3VDIGFuZCBIdUMg ZmlybXdhcmUgc2l6ZXMuCj4KPiB2MzoKPiAgLSBSZWJhc2UKPgo+IHY0Ogo+ICAtIFJlbmFtZWQg dGhlIG5ldyBwYXJhbWV0ZXIgYWRkIHRvIGludGVsX3VjX2Z3X2ZldGNoIChNaWNoYWwpCj4KPiBT aWduZWQtb2ZmLWJ5OiBKYWNraWUgTGkgPHlhb2RvbmcubGlAaW50ZWwuY29tPgo+IENjOiBNaWNo YWwgV2FqZGVjemtvIDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4KPiBDYzogU2FnYXIgQXJ1 biBLYW1ibGUgPHNhZ2FyLmEua2FtYmxlQGludGVsLmNvbT4KPiBDYzogTWljaGFsIFdpbmlhcnNr aSA8bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IEpvaG4gU3BvdHN3b29kIDxqb2hu LmEuc3BvdHN3b29kQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFo dGluZW5AbGludXguaW50ZWwuY29tPgo+IFJldmlld2VkLWJ5OiBKb2huIFNwb3Rzd29vZCA8am9o bi5hLnNwb3Rzd29vZEBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX3VjLmMgICAgfCAxNCArKysrLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF91Y19mdy5jIHwgMzEgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Y19mdy5oIHwgIDcgKysrKystLQo+ICAzIGZpbGVzIGNo YW5nZWQsIDI5IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgIAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfdWMuYwo+IGluZGV4IDFjZmZhZjcuLjczYjhmNmMgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3VjLmMKPiBAQCAtMTcyLDExICsxNzIsOCBAQCB2b2lkIGludGVsX3VjX2luaXRfZWFy bHkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgIAo+ICppOTE1KQo+IAlzYW5pdGl6ZV9vcHRpb25z X2Vhcmx5KGk5MTUpOwo+IC0JaWYgKFVTRVNfR1VDKGk5MTUpKQo+IC0JCWludGVsX3VjX2Z3X2Zl dGNoKGk5MTUsICZndWMtPmZ3KTsKPiAtCj4gLQlpZiAoVVNFU19IVUMoaTkxNSkpCj4gLQkJaW50 ZWxfdWNfZndfZmV0Y2goaTkxNSwgJmh1Yy0+ZncpOwo+ICsJaW50ZWxfdWNfZndfZmV0Y2goaTkx NSwgJmd1Yy0+ZncsIFVTRVNfR1VDKGk5MTUpKTsKPiArCWludGVsX3VjX2Z3X2ZldGNoKGk5MTUs ICZodWMtPmZ3LCBVU0VTX0hVQyhpOTE1KSk7CgpBZ2FpbjogSSdtIGRvbid0IHRoaW5rIHRoYXQg dW5jb25kaXRpb25hbCBmZXRjaCBvZiBIdUMgZncgaXMgYSByaWdodCAgCmNob2ljZS4KV2Ugc2hv dWxkIGxvb2sgZm9yIG90aGVyIG9wdGlvbnMgaG93IHRvIHN1cHBvcnQgZW5hYmxlX2d1YyAxLS0+ MyBzY2VuYXJpby4KCj4gIH0KPiB2b2lkIGludGVsX3VjX2NsZWFudXBfZWFybHkoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gQEAgLTE4NCwxMSArMTgxLDggQEAgdm9pZCBpbnRlbF91 Y19jbGVhbnVwX2Vhcmx5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICAKPiAqaTkxNSkKPiAgCXN0 cnVjdCBpbnRlbF9ndWMgKmd1YyA9ICZpOTE1LT5ndWM7Cj4gIAlzdHJ1Y3QgaW50ZWxfaHVjICpo dWMgPSAmaTkxNS0+aHVjOwo+IC0JaWYgKFVTRVNfSFVDKGk5MTUpKQo+IC0JCWludGVsX3VjX2Z3 X2ZpbmkoJmh1Yy0+ZncpOwo+IC0KPiAtCWlmIChVU0VTX0dVQyhpOTE1KSkKPiAtCQlpbnRlbF91 Y19md19maW5pKCZndWMtPmZ3KTsKPiArCWludGVsX3VjX2Z3X2ZpbmkoJmh1Yy0+ZncpOwo+ICsJ aW50ZWxfdWNfZndfZmluaSgmZ3VjLT5mdyk7Cj4gCWd1Y19mcmVlX2xvYWRfZXJyX2xvZyhndWMp Owo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMg IAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuYwo+IGluZGV4IDZlOGUwYjUu LmMxZmVkMDYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMKPiBAQCAtMzMsMTEg KzMzLDEzIEBACj4gICAqCj4gICAqIEBkZXZfcHJpdjogZGV2aWNlIHByaXZhdGUKPiAgICogQHVj X2Z3OiB1QyBmaXJtd2FyZQo+ICsgKiBAZmV0Y2g6IHdoZXRoZXIgZmV0Y2ggdUMgZmlybXdhcmUg aW50byBHRU0gb2JqZWN0IG9yIG5vdAo+ICAgKgo+IC0gKiBGZXRjaCB1QyBmaXJtd2FyZSBpbnRv IEdFTSBvYmouCj4gKyAqIEZldGNoIGFuZCB2ZXJpZnkgdUMgZmlybXdhcmUgYW5kIGNvcHkgZmly bXdhcmUgZGF0YSBpbnRvIEdFTSBvYmplY3QgIAo+IGlmCj4gKyAqIEBmZXRjaCBpcyB0cnVlLgo+ ICAgKi8KPiAgdm9pZCBpbnRlbF91Y19md19mZXRjaChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gLQkJICAgICAgIHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncpCj4gKwkJICAg ICAgIHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncsIGJvb2wgZmV0Y2gpCj4gIHsKPiAgCXN0cnVj dCBwY2lfZGV2ICpwZGV2ID0gZGV2X3ByaXYtPmRybS5wZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1 X2dlbV9vYmplY3QgKm9iajsKPiBAQCAtMTU0LDE3ICsxNTYsMjQgQEAgdm9pZCBpbnRlbF91Y19m d19mZXRjaChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAgCj4gKmRldl9wcml2LAo+ICAJCWdvdG8g ZmFpbDsKPiAgCX0KPiAtCW9iaiA9IGk5MTVfZ2VtX29iamVjdF9jcmVhdGVfZnJvbV9kYXRhKGRl dl9wcml2LCBmdy0+ZGF0YSwgZnctPnNpemUpOwo+IC0JaWYgKElTX0VSUihvYmopKSB7Cj4gLQkJ ZXJyID0gUFRSX0VSUihvYmopOwo+IC0JCURSTV9ERUJVR19EUklWRVIoIiVzIGZ3IG9iamVjdF9j cmVhdGUgZXJyPSVkXG4iLAo+IC0JCQkJIGludGVsX3VjX2Z3X3R5cGVfcmVwcih1Y19mdy0+dHlw ZSksIGVycik7Cj4gLQkJZ290byBmYWlsOwo+ICsJdWNfZnctPnNpemUgPSBmdy0+c2l6ZTsKPiAr CXVjX2Z3LT5mZXRjaF9zdGF0dXMgPSBJTlRFTF9VQ19GSVJNV0FSRV9WRVJJRklFRDsKCmJ0dywg SSdtIG5vdCBzdXJlIHRoYXQgdGhpcyBuZXcgc3RhdGUgaXMgbmVlZGVkIGF0IGFsbCwgYXMgeW91 IGRvbid0CnBsYW4gdG8gdXNlIHRoYXQgZncgb2JqIGlmIHlvdSBvbmx5IGxvYWRlZCBmdyBibG9i IHRvIHJlYWQgaGVhZGVyLi4uCgo+ICsKPiArCWlmIChmZXRjaCkgewo+ICsJCW9iaiA9IGk5MTVf Z2VtX29iamVjdF9jcmVhdGVfZnJvbV9kYXRhKGRldl9wcml2LCBmdy0+ZGF0YSwKPiArCQkJCQkJ ICAgICAgIGZ3LT5zaXplKTsKPiArCQlpZiAoSVNfRVJSKG9iaikpIHsKPiArCQkJZXJyID0gUFRS X0VSUihvYmopOwo+ICsJCQlEUk1fREVCVUdfRFJJVkVSKCIlcyBmdyBvYmplY3RfY3JlYXRlIGVy cj0lZFxuIiwKPiArCQkJCQkgaW50ZWxfdWNfZndfdHlwZV9yZXByKHVjX2Z3LT50eXBlKSwKPiAr CQkJCQkgZXJyKTsKPiArCQkJZ290byBmYWlsOwo+ICsJCX0KPiArCj4gKwkJdWNfZnctPm9iaiA9 IG9iajsKPiArCQl1Y19mdy0+ZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VT UzsKPiAgCX0KPiAtCXVjX2Z3LT5vYmogPSBvYmo7Cj4gLQl1Y19mdy0+c2l6ZSA9IGZ3LT5zaXpl Owo+IC0JdWNfZnctPmZldGNoX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1M7Cj4g IAlEUk1fREVCVUdfRFJJVkVSKCIlcyBmdyBmZXRjaCAlc1xuIiwKPiAgCQkJIGludGVsX3VjX2Z3 X3R5cGVfcmVwcih1Y19mdy0+dHlwZSksCj4gIAkJCSBpbnRlbF91Y19md19zdGF0dXNfcmVwcih1 Y19mdy0+ZmV0Y2hfc3RhdHVzKSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3VjX2Z3LmggIAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuaAo+ IGluZGV4IGRjMzNiMTIuLmExMzA4YzAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfdWNfZncuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3 LmgKPiBAQCAtMzYsNiArMzYsNyBAQCBlbnVtIGludGVsX3VjX2Z3X3N0YXR1cyB7Cj4gIAlJTlRF TF9VQ19GSVJNV0FSRV9GQUlMID0gLTEsCj4gIAlJTlRFTF9VQ19GSVJNV0FSRV9OT05FID0gMCwK PiAgCUlOVEVMX1VDX0ZJUk1XQVJFX1BFTkRJTkcsCj4gKwlJTlRFTF9VQ19GSVJNV0FSRV9WRVJJ RklFRCwKPiAgCUlOVEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1MKPiAgfTsKPiBAQCAtODQsNiArODUs OCBAQCBjb25zdCBjaGFyICppbnRlbF91Y19md19zdGF0dXNfcmVwcihlbnVtICAKPiBpbnRlbF91 Y19md19zdGF0dXMgc3RhdHVzKQo+ICAJCXJldHVybiAiTk9ORSI7Cj4gIAljYXNlIElOVEVMX1VD X0ZJUk1XQVJFX1BFTkRJTkc6Cj4gIAkJcmV0dXJuICJQRU5ESU5HIjsKPiArCWNhc2UgSU5URUxf VUNfRklSTVdBUkVfVkVSSUZJRUQ6Cj4gKwkJcmV0dXJuICJWRVJJRklFRCI7Cj4gIAljYXNlIElO VEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1M6Cj4gIAkJcmV0dXJuICJTVUNDRVNTIjsKPiAgCX0KPiBA QCAtMTMxLDE0ICsxMzQsMTQgQEAgc3RhdGljIGlubGluZSB2b2lkIGludGVsX3VjX2Z3X3Nhbml0 aXplKHN0cnVjdCAgCj4gaW50ZWxfdWNfZncgKnVjX2Z3KQo+ICAgKi8KPiAgc3RhdGljIGlubGlu ZSB1MzIgaW50ZWxfdWNfZndfZ2V0X3VwbG9hZF9zaXplKHN0cnVjdCBpbnRlbF91Y19mdyAqdWNf ZncpCj4gIHsKPiAtCWlmICh1Y19mdy0+ZmV0Y2hfc3RhdHVzICE9IElOVEVMX1VDX0ZJUk1XQVJF X1NVQ0NFU1MpCj4gKwlpZiAodWNfZnctPmZldGNoX3N0YXR1cyA8IElOVEVMX1VDX0ZJUk1XQVJF X1ZFUklGSUVEKQo+ICAJCXJldHVybiAwOwo+IAlyZXR1cm4gdWNfZnctPmhlYWRlcl9zaXplICsg dWNfZnctPnVjb2RlX3NpemU7Cj4gIH0KPiB2b2lkIGludGVsX3VjX2Z3X2ZldGNoKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkgICAgICAgc3RydWN0IGludGVsX3VjX2Z3 ICp1Y19mdyk7Cj4gKwkJICAgICAgIHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncsIGJvb2wgZmV0 Y2gpOwo+ICBpbnQgaW50ZWxfdWNfZndfdXBsb2FkKHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncs Cj4gIAkJICAgICAgIGludCAoKnhmZXIpKHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncsCj4gIAkJ CQkgICBzdHJ1Y3QgaTkxNV92bWEgKnZtYSkpOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9pbnRlbC1nZngK