From: "Michal Wajdeczko" Subject: Re: [PATCH 1/3] drm/i915/guc: Fix GuC pin bias and WOPCM initialization order Date: Tue, 17 Jul 2018 14:19:19 +0200 Message-ID: References: <20180717115600.5938-1-jakub.bartminski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1758C6E6E0 for ; Tue, 17 Jul 2018 12:19:22 +0000 (UTC) In-Reply-To: <20180717115600.5938-1-jakub.bartminski@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org, =?utf-8?B?SmFrdWIgQmFydG1pxYRza2k=?= List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxNyBKdWwgMjAxOCAxMzo1NTo1OCArMDIwMCwgSmFrdWIgQmFydG1pxYRza2kgIAo8 amFrdWIuYmFydG1pbnNraUBpbnRlbC5jb20+IHdyb3RlOgoKPiBJdCB3b3VsZCBzZWVtIHRoYXQg d2UgYXJlIHVzaW5nIHVuaW5pdGlhbGl6ZWQgV09QQ00gdmFyaWFibGVzIHdoZW4KPiBzZXR0aW5n IHRoZSBHdUMgcGluIGJpYXMuIFRoZSBwaW4gYmlhcyBoYXMgdG8gYmUgc2V0IGFmdGVyIHRoZSBX T1BDTSwKPiBidXQgYmVmb3JlIHRoZSBjYWxsIHRvIGk5MTVfZ2VtX2NvbnRleHRzX2luaXQgd2hl cmUgdGhlIGZpcnN0IGNvbnRleHRzCj4gYXJlIHBpbm5lZCBzbyB0aGUgc2FmZXN0IHBsYWNlIHRv IHNldCBpdCBzZWVtcyB0byBiZSByaWdodCBhZnRlcgo+IGluaXRpYWxpemluZyB0aGUgcmVsZXZh bnQgdmFyaWFibGVzIGluIGludGVsX3dvcGNtX2luaXQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBKYWt1 YiBCYXJ0bWnFhHNraSA8amFrdWIuYmFydG1pbnNraUBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWNoYcWCIFdpbmlhcnNraSA8 bWljaGFsLndpbmlhcnNraUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hh bC53YWpkZWN6a29AaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9ndWMuYyAgIHwgMjEgLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3dvcGNtLmMgfCAxOSArKysrKysrKysrKysrKysrKysrCj4gIDIgZmlsZXMgY2hh bmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMjEgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmMgIAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZ3VjLmMKPiBpbmRleCBlMTJiZDI1OWRmMTcuLjQ3Y2FjZDU5YWMzMiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gQEAgLTI3LDggKzI3LDYgQEAKPiAgI2luY2x1ZGUg ImludGVsX2d1Y19zdWJtaXNzaW9uLmgiCj4gICNpbmNsdWRlICJpOTE1X2Rydi5oIgo+IC1zdGF0 aWMgdm9pZCBndWNfaW5pdF9nZ3R0X3Bpbl9iaWFzKHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7Cj4g LQo+ICBzdGF0aWMgdm9pZCBnZW44X2d1Y19yYWlzZV9pcnEoc3RydWN0IGludGVsX2d1YyAqZ3Vj KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkx NShndWMpOwo+IEBAIC0xNDIsOCArMTQwLDYgQEAgaW50IGludGVsX2d1Y19pbml0X21pc2Moc3Ry dWN0IGludGVsX2d1YyAqZ3VjKQo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSBn dWNfdG9faTkxNShndWMpOwo+ICAJaW50IHJldDsKPiAtCWd1Y19pbml0X2dndHRfcGluX2JpYXMo Z3VjKTsKPiAtCj4gIAlyZXQgPSBndWNfaW5pdF93cShndWMpOwo+ICAJaWYgKHJldCkKPiAgCQly ZXR1cm4gcmV0Owo+IEBAIC02MTEsMjMgKzYwNyw2IEBAIGludCBpbnRlbF9ndWNfcmVzdW1lKHN0 cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgICogYWN0dWFsIEd1QyBXT1BDTSBzaXplLgo+ICAgKi8K PiAtLyoqCj4gLSAqIGd1Y19pbml0X2dndHRfcGluX2JpYXMoKSAtIEluaXRpYWxpemUgdGhlIEd1 QyBnZ3R0X3Bpbl9iaWFzIHZhbHVlLgo+IC0gKiBAZ3VjOiBpbnRlbF9ndWMgc3RydWN0dXJlLgo+ IC0gKgo+IC0gKiBUaGlzIGZ1bmN0aW9uIHdpbGwgY2FsY3VsYXRlIGFuZCBpbml0aWFsaXplIHRo ZSBnZ3R0X3Bpbl9iaWFzIHZhbHVlICAKPiBiYXNlZCBvbgo+IC0gKiBvdmVyYWxsIFdPUENNIHNp emUgYW5kIEd1QyBXT1BDTSBzaXplLgo+IC0gKi8KPiAtc3RhdGljIHZvaWQgZ3VjX2luaXRfZ2d0 dF9waW5fYmlhcyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gLXsKPiAtCXN0cnVjdCBkcm1faTkx NV9wcml2YXRlICppOTE1ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPiAtCj4gLQlHRU1fQlVHX09OKCFp OTE1LT53b3BjbS5zaXplKTsKPiAtCUdFTV9CVUdfT04oaTkxNS0+d29wY20uc2l6ZSA8IGk5MTUt PndvcGNtLmd1Yy5iYXNlKTsKPiAtCj4gLQlndWMtPmdndHRfcGluX2JpYXMgPSBpOTE1LT53b3Bj bS5zaXplIC0gaTkxNS0+d29wY20uZ3VjLmJhc2U7Cj4gLX0KPiAtCj4gIC8qKgo+ICAgKiBpbnRl bF9ndWNfYWxsb2NhdGVfdm1hKCkgLSBBbGxvY2F0ZSBhIEdHVFQgVk1BIGZvciBHdUMgdXNhZ2UK PiAgICogQGd1YzoJdGhlIGd1Ywo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF93b3BjbS5jICAKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcGNtLmMKPiBp bmRleCA3NGJmNzZmM2ZkZGMuLjAyZjYwMmRiOTU0OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF93b3BjbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfd29wY20uYwo+IEBAIC0xNDAsNiArMTQwLDIzIEBAIHN0YXRpYyBpbmxpbmUgaW50IGNoZWNr X2h3X3Jlc3RyaWN0aW9uKHN0cnVjdCAgCj4gZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSwKPiAgCXJl dHVybiBlcnI7Cj4gIH0KPiArLyoqCj4gKyAqIHdvcGNtX2luaXRfZ3VjX2dndHRfcGluX2JpYXMo KSAtIEluaXRpYWxpemUgdGhlIEd1QyBnZ3R0X3Bpbl9iaWFzICAKPiB2YWx1ZS4KPiArICogQHdv cGNtOiBwb2ludGVyIHRvIGludGVsX3dvcGNtLgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0aW9uIHdp bGwgY2FsY3VsYXRlIGFuZCBpbml0aWFsaXplIHRoZSBHdUMgZ2d0dF9waW5fYmlhcyAgCj4gdmFs dWUgYmFzZWQKPiArICogb24gb3ZlcmFsbCBXT1BDTSBzaXplIGFuZCBHdUMgV09QQ00gc2l6ZS4K PiArICovCj4gK3N0YXRpYyB2b2lkIHdvcGNtX2luaXRfZ3VjX2dndHRfcGluX2JpYXMoc3RydWN0 IGludGVsX3dvcGNtICp3b3BjbSkKPiArewo+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5 MTUgPSB3b3BjbV90b19pOTE1KHdvcGNtKTsKPiArCj4gKwlHRU1fQlVHX09OKCF3b3BjbS0+c2l6 ZSk7Cj4gKwlHRU1fQlVHX09OKHdvcGNtLT5zaXplIDwgd29wY20tPmd1Yy5iYXNlKTsKPiArCj4g KwlpOTE1LT5ndWMuZ2d0dF9waW5fYmlhcyA9IHdvcGNtLT5zaXplIC0gd29wY20tPmd1Yy5iYXNl OwoKSG1tLCBJIGRvbid0IGxpa2UgdGhlIGlkZWEgdG8gbW9kaWZ5IEd1QyAob3IgR0dUVCBsYXRl ciBvbikgaW50ZXJuYWxzCmRpcmVjdGx5IGZyb20gV09QQ00gcHJpdmF0ZSBmdW5jdGlvbnMuCgpN YXliZSB5b3UgY2FuIGNoYW5nZSB5b3VyIHNlcmllcyB0byBmaXJzdCBtb3ZlIHBpbl9iaWFzIGZy b20gR3VDIHRvCkdHVFQgYW5kIHRoZW4gaW1tZWRpYXRlbHkgc2V0dXAgaXQgaW5zaWRlIGk5MTVf Z2VtX2luaXRfZ2d0dCgpIHdoaWNoCmlzIGNhbGxlZCBhZnRlciBpbnRlbF93b3BjbV9pbml0KCkg YW5kIGJlZm9yZSBpOTE1X2dlbV9jb250ZXh0c19pbml0KCkKCk1pY2hhbAoKCj4gK30KPiArCj4g IC8qKgo+ICAgKiBpbnRlbF93b3BjbV9pbml0KCkgLSBJbml0aWFsaXplIHRoZSBXT1BDTSBzdHJ1 Y3R1cmUuCj4gICAqIEB3b3BjbTogcG9pbnRlciB0byBpbnRlbF93b3BjbS4KPiBAQCAtMjA3LDYg KzIyNCw4IEBAIGludCBpbnRlbF93b3BjbV9pbml0KHN0cnVjdCBpbnRlbF93b3BjbSAqd29wY20p Cj4gIAl3b3BjbS0+Z3VjLmJhc2UgPSBndWNfd29wY21fYmFzZTsKPiAgCXdvcGNtLT5ndWMuc2l6 ZSA9IGd1Y193b3BjbV9zaXplOwo+ICsJd29wY21faW5pdF9ndWNfZ2d0dF9waW5fYmlhcyh3b3Bj bSk7Cj4gKwo+ICAJcmV0dXJuIDA7Cj4gIH0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==