From: Andi Kleen Subject: Re: [RFC PATCH 00/35] Xen i386 paravirtualization support Date: 09 May 2006 17:20:11 +0200 Message-ID: References: <20060509084945.373541000@sous-sol.org> <4460AC01.5020503@mbligh.org> <20060509150701.GA14050@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: In-Reply-To: <20060509150701.GA14050@infradead.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Hellwig Cc: Chris Wright , virtualization@lists.osdl.org, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org Christoph Hellwig writes: > On Tue, May 09, 2006 at 07:49:37AM -0700, Martin J. Bligh wrote: > > Congrats on getting this thrashed out. A few comments, most of which are > > boring style nits, but nonetheless ... will try to take a proper look > > later. > > > > General comment: > > > > Why is this style used: > > > > HYPERVISOR_foo_bar ? > > > > ie the capitalization of HYPERVISOR. Doesn't seem to fit with the rest > > of the kernel style. > > It's also wrong. There's more than one hypervisor and Xen shouldn't just > grab this namespace. make it xen_ or xenhv_. You should reject the recent "hypervisor file system" with the same argument then. -Andi