From: Kai Krakow Subject: Re: [PATCH 1/2] drm/i915: allow to select rc6 modes via kernel parameter Date: Sat, 11 Feb 2012 19:13:52 +0100 Message-ID: References: <1328963655-12128-1-git-send-email-eugeni.dodonov@intel.com> <1328963655-12128-2-git-send-email-eugeni.dodonov@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from plane.gmane.org (plane.gmane.org [80.91.229.3]) by gabe.freedesktop.org (Postfix) with ESMTP id CC0469E73D for ; Sat, 11 Feb 2012 10:15:24 -0800 (PST) Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1RwHTm-0007jk-KQ for intel-gfx@lists.freedesktop.org; Sat, 11 Feb 2012 19:15:22 +0100 Received: from adsl-9-130.nordcom.uni-bremen.de ([134.102.9.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 11 Feb 2012 19:15:22 +0100 Received: from hurikhan77 by adsl-9-130.nordcom.uni-bremen.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 11 Feb 2012 19:15:22 +0100 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Chris Wilson schrieb: >> + if (rc6_mode > 0) { > I'm a little uneasy mixing signs and bitmasks, and this test looks a > little pointless as intel_enable_rc6 now returns the bitmask. Kill it > and we kill one level of indentation! I think not, because Eugeni documented "-1" as the chipset default... Just my 2 cents... Regards, Kai