Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09D3C41513 for ; Tue, 8 Aug 2023 17:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E10266B0071; Tue, 8 Aug 2023 13:32:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC08A6B0074; Tue, 8 Aug 2023 13:32:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C61588D0001; Tue, 8 Aug 2023 13:32:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B436F6B0071 for ; Tue, 8 Aug 2023 13:32:10 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 873FE120C6C for ; Tue, 8 Aug 2023 17:32:10 +0000 (UTC) X-FDA: 81101630820.27.67E4146 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf28.hostedemail.com (Postfix) with ESMTP id 3110BC001C for ; Tue, 8 Aug 2023 17:32:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=QIb8cGi7; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=l7U6RjUG; dmarc=none; spf=pass (imf28.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691515927; a=rsa-sha256; cv=none; b=VdSGfZFlX7Va7Y0FzdVYBv7n0rdu5JVo9/0eCnPVMrWf/IRxEa4CC4vGSTfaMYnuBFpE3m elSgBgP27ol9GToVUsmDWx7ED44Oh7UPwjOvUAFw/S8hxnz8Eimi2YMNu35b+Rf/Us/4HK GnJsCpO9Na/INpqs9yVUVMLhoVJhnT4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=QIb8cGi7; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=l7U6RjUG; dmarc=none; spf=pass (imf28.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691515927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rMUaHZaSAI4l93e7AeZWrkXodMmRgdTWwjGdICmzDaY=; b=7k9a1S9ZxdIwEpbZ3ZjR4U5BAFSk2SRkRxydoNqqPmy5mIHImFz4WH+UpRu3n59q1tOfv0 Kff53sy4QF1mbnA476KwRWg7eNPDWbmXOtXJufeeY9oGpIE/xzzLezk/XVftNbzE6udX1n RgE8RECuNd0T5i170CwOBI1zdjxkEtc= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BFE2A5C009D; Tue, 8 Aug 2023 13:32:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 08 Aug 2023 13:32:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1691515924; x=1691602324; bh=rM UaHZaSAI4l93e7AeZWrkXodMmRgdTWwjGdICmzDaY=; b=QIb8cGi7i1UpCeFo5r lPDUKHa3UY9ysLj4xsmXkoQgvBnocxeYG0J5izW/BE4h7jAd0iuMvoFXviIVuqjU klbeJ0cZ8iy+M0HSct94mQUeO5Anw0ggFpYldatqYosC+89HxfY4nRT2YxEwZ87N AUa032AxMKzHx3eOvh/u8IzjecbYVvlnIzVdGqs9PdD/Vjj0AYzNjyRK5GoGoghU YzvDY5hvLZOvbYdJXEhDPqjPbnOt9pIAIj1lFWq+DPxlbT2/6y5yuaF9kWuKSexX bbxGShvrwZaCorxqbR4fQ1X553N6umvdv5D2sIt373aRzFqA4rHe5VrG9ZQqBXF5 i56g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691515924; x=1691602324; bh=rMUaHZaSAI4l9 3e7AeZWrkXodMmRgdTWwjGdICmzDaY=; b=l7U6RjUGhd233kTpEmkm+1CLdkldm P/2Bkl4+Awfzq9S1G9OmEPBEy+17nWwdTGB4KB18+fV+EFau+oDwheZDXD2FyPb5 zSGkfWbcI5YIyZcV9ligquRd8/vW/gdugihmSiZQMDAEUQYvwv2Wb1DxOdpog+DD 0gnFnOGvfevxWVD0eQ+2GapGhe8QOdDe7bTDCqvje3wDMcwzlPJPFlk8NxvfsT2J nXM9C0cIQjlBuspJUlHzmkjyjAvaSlO0+JvfMMdnCS3OYa7YBjKIOR2/sElWcFXe O/7mfnzROWwl3puMBQXllZdeMhRIxCjAeSZvrP00SpXm8tVF6IdrW1x4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrledvgdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepufhtvghf rghnucftohgvshgthhcuoehshhhrseguvghvkhgvrhhnvghlrdhioheqnecuggftrfgrth htvghrnhepveelgffghfehudeitdehjeevhedthfetvdfhledutedvgeeikeeggefgudeg uedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsh hhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 8 Aug 2023 13:32:03 -0400 (EDT) References: <20230728163952.4634-1-ayush.jain3@amd.com> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: Ayush Jain Cc: akpm@linux-foundation.org, shuah@kernel.org, pasha.tatashin@soleen.com, zhansayabagdaulet@gmail.com, tyhicks@linux.microsoft.com, raghavendra.kt@amd.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Narasimhan.V@amd.com, Santosh.Shukla@amd.com, David Hildenbrand Subject: Re: [PATCH v2 1/2] selftests: mm: ksm: Fix incorrect evaluation of parameter Date: Tue, 08 Aug 2023 10:31:24 -0700 In-reply-to: <20230728163952.4634-1-ayush.jain3@amd.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3110BC001C X-Stat-Signature: qbq49qcz9c3ognm4aiuwtkouwzzxhnat X-HE-Tag: 1691515926-590468 X-HE-Meta: U2FsdGVkX19P/6Cq/W6o/dcb6/7QFAlGhRcJY5kPU/d8y5t8pXyHmliUTgiuMTcZDRCViBTis6KOPQsxGwTxDuqFHwKSX7Gcy5CcLy+AD58DjibZMVrrj4N1/i/1hBATtVbvz519aHquT5v3gtDeS3qdV9oH0I75pPuvllcekW9mHB3JHhtxti+CEfY0i/HcEL/zMFqHo9wNmajCJP46Yp8cwvCat5zEBOwb6g1cKYnj9/1W9CYFzikIhA4AgqX7hSquA1dlD38a2YIUwx07eshqGrbGPPGUKgWjWtz2GZoCYb3LfXjCH0+AtmUun/04RxncfW0VsYevnWWj1MqokHcpYtS3OmMRkykrM6lA8PSJf4SPm+vco3LHv7axYWHdQ9Ou1upIy9pkwtkxQP64xmJ7v80EBGpQy6GWtnD4Gm9Mp3n4GWzF7b5FEJpes/0KZkF8M/Ku6hkd/13nH2o0SRL/WksdRajTLVPRJI0uqeV3aifTUbOMqoYEwWonevcQiR1JJSFUgxfxqoA6bbTvHTcNpp/pqkhACrrTdIPzTJm+HHdXynTfFpp5lV0NIGLVRCMYVxEU7WU+TWsAlNTRpe2JSl8iwu0SRU1DaFEe6QCryQBmuSAdtMoDuMi6VEGe3a/v0CV+Q7szPSv/qXDA94WEj1WK20t/pyPpaB2hENdwNs8a/ew5drE/fe+L8eg4c4JiyYNyt4mx0kjdrnOAIbu6alx1y6MjSvIFS1JAzXxufqpjDRzxxAujK3Sf70uEydYGasVj/aKFbYeCaHv6ZUAAW49oVISbYYaWfeochabeb7RuX2R7EjxMRatqoBqb2hV4+uHNxeXjuTQLtz5OkEnPzDFw71CgFLOV4mlTaTfnAQm07EMH0EbQevPWFFK0clEm8AkJKFfQ+spJzsXo/nTv/WmVV5wz9y8QvjTFaxYdpiOZtJf5rwEe/C++HOdewEgtYRGBlX5qi0qIb87 Pbnz0u5K 6nsc5jS56B1ehPePTc/o2c3zmBa1naVlzc1Mz92DbdcotoCjbvp57AcLDnWnm+SbBmd2pIu0EpdsuZPzxb7rG9VjVJs4PRquZfHnoTyOwWZ6695G/ZkENxZiKAhxVB6GP5lwH8h1oKgTCsSyDQ28Hmq5jg3yqjg/hvCt5FHtHzGDtYGM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Ayush Jain writes: > A missing break in kms_tests leads to kselftest hang when the > parameter -s is used. > In current code flow because of missing break in -s, -t parses > args spilled from -s and as -t accepts only valid values as 0,1 > so any arg in -s >1 or <0, gets in ksm_test failure > > This went undetected since, before the addition of option -t, > the next case -M would immediately break out of the switch > statement but that is no longer the case > > Add the missing break statement. > > ----Before---- > ./ksm_tests -H -s 100 > Invalid merge type > > ----After---- > ./ksm_tests -H -s 100 > Number of normal pages: 0 > Number of huge pages: 50 > Total size: 100 MiB > Total time: 0.401732682 s > Average speed: 248.922 MiB/s > > Fixes: 07115fcc15b4 ("selftests/mm: add new selftests for KSM") > > Signed-off-by: Ayush Jain > Reviewed-by: David Hildenbrand > --- > v1 -> v2 > collect Reviewed-by from David > Updated Fixes tag from commit 9e7cb94ca218 to 07115fcc15b4 > > tools/testing/selftests/mm/ksm_tests.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/mm/ksm_tests.c b/tools/testing/selftests/mm/ksm_tests.c > index 435acebdc325..380b691d3eb9 100644 > --- a/tools/testing/selftests/mm/ksm_tests.c > +++ b/tools/testing/selftests/mm/ksm_tests.c > @@ -831,6 +831,7 @@ int main(int argc, char *argv[]) > printf("Size must be greater than 0\n"); > return KSFT_FAIL; > } > + break; > case 't': > { > int tmp = atoi(optarg); Acked-by: Stefan Roesch