From: "Charles Coffing" Subject: [PATCH] get_current() called before set_current() Date: Tue, 31 Aug 2004 13:19:37 -0600 Sender: xen-devel-admin@lists.sourceforge.net Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__Part8BABF359.0__=" Return-path: Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: xen-devel@lists.sourceforge.net List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__Part8BABF359.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline The recent change that added debugging to spinlocks (cset 1.1278.1.1) caused get_current() to be called earlier in the boot process. In fact, it is now called before set_current(). If assertions are compiled in, this ultimately causes a triple fault when Xen tries to print the banner. If assertions aren't compiled in, memory corruption results (although currently this corruption appears to be benign.) The attached patch moves the first set_current() call a bit earlier in the boot process. Thanks, Charles --=__Part8BABF359.0__= Content-Type: application/octet-stream; name="setcurrent.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="setcurrent.patch" LS0tIHhlbm8tdW5zdGFibGUuYmsuYmFrL3hlbi9jb21tb24va2VybmVsLmMJMjAwNC0wOC0zMCAw ODoyNzozMi4wMDAwMDAwMDAgLTA2MDAKKysrIHhlbm8tdW5zdGFibGUuYmsveGVuL2NvbW1vbi9r ZXJuZWwuYwkyMDA0LTA4LTMxIDEzOjE2OjE4LjAwMDAwMDAwMCAtMDYwMApAQCAtMTgzLDYgKzE4 Myw5IEBACiAgICAgICAgIH0KICAgICB9CiAKKyAgICAvKiBNdXN0IGRvIHRoaXMgZWFybHkgLS0g ZS5nLiwgc3BpbmxvY2tzIHJlbHkgb24gZ2V0X2N1cnJlbnQoKS4gKi8KKyAgICBzZXRfY3VycmVu dCgmaWRsZTBfdGFzayk7CisKICAgICAvKiBXZSBpbml0aWFsaXNlIHRoZSBzZXJpYWwgZGV2aWNl cyB2ZXJ5IGVhcmx5IHNvIHdlIGNhbiBnZXQgZGVidWdnaW5nLiAqLwogICAgIHNlcmlhbF9pbml0 X3N0YWdlMSgpOwogCkBAIC0yMTgsOCArMjIxLDYgQEAKICAgICAgICAgZm9yICggOyA7ICkgOwog ICAgIH0KIAotICAgIHNldF9jdXJyZW50KCZpZGxlMF90YXNrKTsKLQogICAgIHhlbmhlYXBfcGh5 c19lbmQgPSBvcHRfeGVuaGVhcF9tZWdhYnl0ZXMgPDwgMjA7CiAKICAgICBtYXhfbWVtID0gbWF4 X3BhZ2UgPSAobWJpLT5tZW1fdXBwZXIrMTAyNCkgPj4gKFBBR0VfU0hJRlQgLSAxMCk7Cg== --=__Part8BABF359.0__=-- ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click