Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBD7BC4361B for ; Tue, 8 Dec 2020 16:57:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CB8523B01 for ; Tue, 8 Dec 2020 16:57:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CB8523B01 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B1D9D16DB; Tue, 8 Dec 2020 17:57:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B1D9D16DB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1607446671; bh=GTfG/hII+8aGc5HK7jw1F4GC75tWRxMra0xSkBXMJpU=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ODycJl3Ze/sLVyoOrqixVVnqhE6Gd2kVESUHGTaNkytsC0Z9tePLVhdZCtl/5PlQl eLHhQR5LwDFP4EILLRsVYiSP1vM0YhFA6fo3NYcDZilJh6LFmYyzOmULLCRe5NF4X0 4CrthleZBDv1FUY84i5tfARjloXnI/Z+JTsozRbE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E6B68F80164; Tue, 8 Dec 2020 17:57:00 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3EE67F8019D; Tue, 8 Dec 2020 17:57:00 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 29C68F80130 for ; Tue, 8 Dec 2020 17:56:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 29C68F80130 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 92F0BAC94; Tue, 8 Dec 2020 16:56:50 +0000 (UTC) Date: Tue, 08 Dec 2020 17:56:50 +0100 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH] ALSA: hda/proc - print DP-MST connections In-Reply-To: <20201208160941.2797510-1-kai.vehmanen@linux.intel.com> References: <20201208160941.2797510-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 08 Dec 2020 17:09:41 +0100, Kai Vehmanen wrote: > > To help in debugging issues with DisplayPort Multi-Stream Transport (aka > DP-MST) support, print information of active connections for > each device of a display audio pin widget. > > Example output with the patch with two monitors connected to a DP-MST hub: Somehow the text is folded irregularly... > Devices: 4 > Dev 00: PD = 0, ELDV = 0, IA = 0, Connections [ 0x03* 0x05 0x07 0x09 ] > Dev 01: PD = 1, ELDV = 1, IA = 0, Connections [ 0x03* 0x05 0x07 0x09 ] > *Dev 02: PD = 1, ELDV = 1, IA = 0, Connections [ 0x03 0x05* 0x07 0x09 ] > Dev 03: PD = 0, ELDV = 0, IA = 0, Connections [ 0x03* 0x05 0x07 0x09 ] > Connection: 4 > 0x03 0x05* 0x07 0x09 > > Format of existing "Connection:" entry is left intact to keep > compatibility. > > Signed-off-by: Kai Vehmanen > --- > sound/pci/hda/hda_proc.c | 39 ++++++++++++++++++++++++++++++++++++++- > 1 file changed, 38 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c > index 0631f31ef87f..e1cba574cadb 100644 > --- a/sound/pci/hda/hda_proc.c > +++ b/sound/pci/hda/hda_proc.c > @@ -679,6 +679,39 @@ static void print_gpio(struct snd_info_buffer *buffer, > print_nid_array(buffer, codec, nid, &codec->nids); > } > > +static void print_dpmst_connections(struct snd_info_buffer *buffer, struct hda_codec *codec, > + hda_nid_t nid, int dev_num) > +{ > + int c, conn_len, curr, dev_id_saved; > + hda_nid_t *conn; > + > + conn_len = snd_hda_get_num_raw_conns(codec, nid); > + if (conn_len <= 0) > + return; > + > + conn = kmalloc_array(conn_len, > + sizeof(hda_nid_t), > + GFP_KERNEL); Missing NULL check? Also you can fold into a single line. The rest looks good. thanks, Takashi