Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01754C4346E for ; Thu, 24 Sep 2020 15:50:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7486C23600 for ; Thu, 24 Sep 2020 15:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="djzEvHn6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7486C23600 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id EB97B17E3; Thu, 24 Sep 2020 17:49:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz EB97B17E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1600962596; bh=4wxF9w4Aur9JK2xtnAyKDA5Nv+xeufgWyAKw1Trv9dg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=djzEvHn6CFIlf/78pppbl+XX09dJzwhMqdIQCN5rWI4o3amVpeKZVpVu73U3UOuks KS8L0hSnTR5cAiN0to51RCL0Pa3vJoQ6bqw8uPWGfw0k8kINTr4gh/ei1e2F24TthF y3usUdzCYPePosdD+b/JXjwkblmX8tPUgILKxEWo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5B5F8F800DA; Thu, 24 Sep 2020 17:49:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CDD6BF80229; Thu, 24 Sep 2020 17:49:03 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E1A01F800DA for ; Thu, 24 Sep 2020 17:48:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E1A01F800DA X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F2D9CABD1; Thu, 24 Sep 2020 15:48:52 +0000 (UTC) Date: Thu, 24 Sep 2020 17:48:52 +0200 Message-ID: From: Takashi Iwai To: Kai Vehmanen Subject: Re: [PATCH] ALSA: hda - add missing documentation to hdac_i915 In-Reply-To: <20200924154043.3392898-1-kai.vehmanen@linux.intel.com> References: <20200924154043.3392898-1-kai.vehmanen@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 24 Sep 2020 17:40:43 +0200, Kai Vehmanen wrote: > > Document missing function arguments and fix make W=1 > warning: > > sound/hda/hdac_i915.c:80: warning: Function parameter or member 'i915' not described in 'connectivity_check' > sound/hda/hdac_i915.c:80: warning: Function parameter or member 'hdac' not described in 'connectivity_check' > > Fixes: 7b882fe3e3e8 ('ALSA: hda - handle multiple i915 device instances') > Signed-off-by: Kai Vehmanen Do we really need to put this internal function in the API documents? If not, the right fix would be to drop the kerneldoc marker instead. thanks, Takashi > --- > sound/hda/hdac_i915.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c > index d236e497435d..9592d0c0c254 100644 > --- a/sound/hda/hdac_i915.c > +++ b/sound/hda/hdac_i915.c > @@ -75,6 +75,8 @@ EXPORT_SYMBOL_GPL(snd_hdac_i915_set_bclk); > > /** > * Returns true if the devices can be connected for audio. > + * @i915: i915 PCI device > + * @hdac: HDA audio controller PCI device > */ > static bool connectivity_check(struct pci_dev *i915, struct pci_dev *hdac) > { > -- > 2.27.0 >