From: Takashi Iwai Subject: Re: [PATCH v2 3/9] ALSA: caiaq: Add a sanity check for invalid EPs Date: Wed, 11 Oct 2017 17:05:47 +0200 Message-ID: References: <20171011103646.11879-1-tiwai@suse.de> <20171011103646.11879-4-tiwai@suse.de> <20171011142031.GY4269@localhost> <20171011144910.GD4269@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20171011144910.GD4269@localhost> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Johan Hovold Cc: alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Andrey Konovalov , Greg KH List-Id: alsa-devel@alsa-project.org On Wed, 11 Oct 2017 16:49:10 +0200, Johan Hovold wrote: > > On Wed, Oct 11, 2017 at 04:40:36PM +0200, Takashi Iwai wrote: > > On Wed, 11 Oct 2017 16:20:31 +0200, > > Johan Hovold wrote: > > > > Unrelated to this patch, but this driver fails to kill the ep1_in_urb > > > (which is submitted in this function) in case of later probe errors. > > > This can lead to use-after-free or crashes in the completion callback. > > > > Yes, a good catch. Below is the fix patch. > > > -- 8< -- > > From: Takashi Iwai > > Subject: [PATCH] ALSA: caiaq: Fix stray URB at probe error path > > > > caiaq driver doesn't kill the URB properly at its error path during > > the probe, which may lead to a use-after-free error later. This patch > > addresses it. > > > > Reported-by: Johan Hovold > > Signed-off-by: Takashi Iwai > > Looks good to me: > > Reviewed-by: Johan Hovold Thanks. It's rather a material for for-linus with Cc to stable, so marked it and queued. Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html