From: Takashi Iwai Subject: Re: [PATCH v2] ASoC: Intel: byt-max98090: Add GPIO ACPI mapping table Date: Sat, 10 Jun 2017 21:41:34 +0200 Message-ID: References: <20170610163741.49214-1-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id E37B826698E for ; Sat, 10 Jun 2017 21:41:35 +0200 (CEST) In-Reply-To: <20170610163741.49214-1-andriy.shevchenko@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andy Shevchenko Cc: Nicolas Porcel , Mark Brown , Dmitry Torokhov , Liam Girdwood , alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Sat, 10 Jun 2017 18:37:41 +0200, Andy Shevchenko wrote: > > +static const struct acpi_gpio_params hp_gpios = { 0, 0, false }; > +static const struct acpi_gpio_params mic_gpios = { 1, 0, false }; > + > +static const struct acpi_gpio_mapping acpi_byt_max98090_gpios[] = { > + { "hp-gpios", &hp_gpios, 1 }, > + { "mic-gpios", &mic_gpios, 1 }, Better to use C99 style init? I'm not always a fan of it, but this seems deserving. From the above, it's difficult to know which zero is for what. thanks, Takashi