From: Takashi Iwai Subject: Re: [PATCH 15/15] ALSA: line6: Remove double line6_pcm_release() after failed acquire. Date: Fri, 12 Aug 2016 10:46:53 +0200 Message-ID: References: <1470942147-19848-1-git-send-email-dev@andree.sk> <1470942147-19848-16-git-send-email-dev@andree.sk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 4439F26769A for ; Fri, 12 Aug 2016 10:46:54 +0200 (CEST) In-Reply-To: <1470942147-19848-16-git-send-email-dev@andree.sk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Andrej Krutak Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Thu, 11 Aug 2016 21:02:27 +0200, Andrej Krutak wrote: > > If there's an error, pcm is released in line6_pcm_acquire already. > > Signed-off-by: Andrej Krutak This looks like a fix independent from your patchset. In that case, submit it individually so that I can merge it beforehand. Takashi > --- > sound/usb/line6/pcm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/usb/line6/pcm.c b/sound/usb/line6/pcm.c > index 13b3b27..455244c 100644 > --- a/sound/usb/line6/pcm.c > +++ b/sound/usb/line6/pcm.c > @@ -55,7 +55,6 @@ static int snd_line6_impulse_volume_put(struct snd_kcontrol *kcontrol, > err = line6_pcm_acquire(line6pcm, LINE6_STREAM_IMPULSE, true); > if (err < 0) { > line6pcm->impulse_volume = 0; > - line6_pcm_release(line6pcm, LINE6_STREAM_IMPULSE); > return err; > } > } else { > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel >