From: Takashi Iwai Subject: Re: [PATCH 0/7] ASoC: Cleanup AC'97 reset handling Date: Wed, 22 Jul 2015 10:48:24 +0200 Message-ID: References: <1437508386-13828-1-git-send-email-lars@metafoo.de> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id EDFB8260664 for ; Wed, 22 Jul 2015 10:48:24 +0200 (CEST) In-Reply-To: <1437508386-13828-1-git-send-email-lars@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Liam Girdwood , Mark Brown , Manuel Lauss , Charles Keepax List-Id: alsa-devel@alsa-project.org On Tue, 21 Jul 2015 21:52:59 +0200, Lars-Peter Clausen wrote: > > AC'97 devices require that they are properly reset before they can be used. > Currently ASoC drivers do this by hand each on its own. This lead to many > similar but slightly different implementations. E.g. Some supporting warm > reset, some don't. And even though AC'97 do have a device ID which uniquely > identifies a device most drivers only use the content of register 0 for > device verification. > > This patch series introduces a new generic helper function in the ALSA > AC'97 core that can be used to reset a device and verify its ID if > required. And then converts drivers to use this new helper function instead > of custom code. > > snd_soc_new_ac97_codec() is extended to be able to perform a reset between > the allocation and registration of the AC'97 device, this will allow more > drivers to use it. > > - Lars > > Lars-Peter Clausen (7): > ALSA: ac97: Add helper function to reset the AC97 device > ASoC: ac97: Add support for resetting device before registration > ASoC: ad1980: Use core AC'97 reset helper > ASoC: stac9766: Use core reset helper > ASoC: wm9705: Use core AC'97 reset helper > ASoC: wm9712: Use core AC'97 reset helper > ASoC: wm9713: Use core AC'97 reset helper Feel free to take my ack for all: Reviewed-by: Takashi Iwai thanks, Takashi