From: Takashi Iwai Subject: Re: [PATCH v4 2/7] ASoC: Intel: mrfld - Add DSP load and management Date: Fri, 17 Oct 2014 12:04:56 +0200 Message-ID: References: <1413469819-18775-1-git-send-email-vinod.koul@intel.com> <1413469819-18775-3-git-send-email-vinod.koul@intel.com> <20141017094413.GF3771@sirena.org.uk> <20141017091816.GP1638@intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 76A2A2608AF for ; Fri, 17 Oct 2014 12:04:57 +0200 (CEST) In-Reply-To: <20141017091816.GP1638@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: alsa-devel@alsa-project.org, Mark Brown , subhransu.s.prusty@intel.com, lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org At Fri, 17 Oct 2014 14:48:16 +0530, Vinod Koul wrote: > > On Fri, Oct 17, 2014 at 11:44:14AM +0200, Mark Brown wrote: > > On Thu, Oct 16, 2014 at 08:00:14PM +0530, Vinod Koul wrote: > > > > > +static void memcpy32_toio(void __iomem *dst, const void *src, int count) > > > +{ > > > + int i; > > > + const u32 *src_32 = src; > > > + u32 *dst_32 = dst; > > > + > > > + for (i = 0; i < count/sizeof(u32); i++) > > > + writel(*src_32++, dst_32++); > > > +} > > > > We also have a memcpy32_toio in atmel_nand.c which I pointed out before > > and now another in mxc_nand.c. All of which use different writel > > variants. This isn't awesome, we should at least try to clean this up > > rather than add another duplicate - by the time we're onto the third > > user there's a clear need for something generic. Do you have any > > thoughts on dealing with this? > I dont mind moving this and other users to common handler. I can send a > patch to add that. I think Subranshu did send one but that needs to be > improved upon. Also this should be in BYT driver as well. > > But creates dependency for us > > > > Otherwise the patch looks good. > Thanks, since the size is bit on higher size and no other issues, would it > be okay to merge this. > > I will work on moving memcpy32_toio to core and move users as well :) We can move them into sound/core/memory.c. They are pretty small and useful. Takashi