From: Takashi Iwai Subject: Re: [RFC PATCH 2/2] ASoC: add compress stream support Date: Mon, 06 Aug 2012 10:01:32 +0200 Message-ID: References: <1343716900-23491-1-git-send-email-vinod.koul@linux.intel.com> <1343716900-23491-3-git-send-email-vinod.koul@linux.intel.com> <20120802180926.GL4537@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A0C82265365 for ; Mon, 6 Aug 2012 09:31:48 +0200 (CEST) In-Reply-To: <20120802180926.GL4537@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Vinod Koul , alsa-devel@alsa-project.org, pierre-louis.bossart@linux.intel.com, ramesh.babu@intel.com, namartax.kohli@intel.com, lrg@ti.com List-Id: alsa-devel@alsa-project.org At Thu, 2 Aug 2012 19:09:27 +0100, Mark Brown wrote: > > > +int soc_compr_set_params(struct snd_compr_stream *cstream, > > + struct snd_compr_params *params) > > +{ > > > + snd_soc_dai_digital_mute(codec_dai, 0); > > This looks wrong - the unmute should be associated with the start of the > data transfer rather than the configuration. But we don't have any > other ops... can we have one, or a non-atomic trigger? I've been thinking of the possibility for a long time. The problem is how to handle the trigger(STOP) gracefully. Maybe creating a dedicated work struct would be required. Also it'd require a new schedulable lock for the substream on the top of snd_pcm_stream_lock*(). But before adding it, we should revisit the current lock mess in the code... Takashi