From: Takashi Iwai Subject: Re: [PATCH] ALSA: Add missing include of pcm.h to pcm_params.h Date: Wed, 20 Jun 2012 17:51:29 +0200 Message-ID: References: <1340130709-2857-1-git-send-email-broonie@opensource.wolfsonmicro.com> <20120620093425.GA3978@opensource.wolfsonmicro.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 2E31724676 for ; Wed, 20 Jun 2012 17:51:30 +0200 (CEST) In-Reply-To: <20120620093425.GA3978@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org At Wed, 20 Jun 2012 10:34:25 +0100, Mark Brown wrote: > > On Wed, Jun 20, 2012 at 07:47:25AM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > > There's a dependency but no #include. > > > I don't mind to put it, but it wasn't done because we didn't want to > > let the driver code including only pcm_params.h without pcm.h. > > I noticed it because I was writing some library code which only directly > referenced things in pcm_params.h so just included that directly. The > general idea is that headers shouldn't have external dependencies... True. This can be an endless bikeshed discussion, so I simply applied the patch now. thanks, Takashi